Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/Source/core/paint/TableRowPainter.cpp

Issue 2884763003: Combine and simplify LayoutTableSection::DirtiedRows() and DirtiedEffectiveColumns() (Closed)
Patch Set: Rebase on origin/master Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableRowPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/TableRowPainter.cpp b/third_party/WebKit/Source/core/paint/TableRowPainter.cpp
index 700a2e8e96be7a8fcb1fd8ba17fd0ea5c57e63d1..3edfcc566c388e8f4715e1d8d549fc0f96132e8a 100644
--- a/third_party/WebKit/Source/core/paint/TableRowPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/TableRowPainter.cpp
@@ -32,8 +32,10 @@ void TableRowPainter::Paint(const PaintInfo& paint_info,
cull_rect.MoveBy(layout_table_row_.PhysicalLocation(section));
LayoutRect logical_rect_in_section =
section->LogicalRectForWritingModeAndDirection(cull_rect);
- CellSpan dirtied_columns =
- section->DirtiedEffectiveColumns(logical_rect_in_section);
+ CellSpan dirtied_rows;
+ CellSpan dirtied_columns;
+ section->DirtiedRowsAndEffectiveColumns(logical_rect_in_section,
+ dirtied_rows, dirtied_columns);
PaintBoxDecorationBackground(paint_info, paint_offset, dirtied_columns);
}
@@ -96,7 +98,7 @@ void TableRowPainter::PaintBoxDecorationBackground(
if (has_background) {
PaintInfo paint_info_for_cells = paint_info.ForDescendants();
- for (auto c = dirtied_columns.Start(); c < dirtied_columns.end(); c++) {
+ for (auto c = dirtied_columns.Start(); c < dirtied_columns.End(); c++) {
if (const auto* cell =
section->OriginatingCellAt(layout_table_row_.RowIndex(), c))
PaintBackgroundBehindCell(*cell, paint_info_for_cells, paint_offset);

Powered by Google App Engine
This is Rietveld 408576698