Combine and simplify LayoutTableSection::DirtiedRows() and DirtiedEffectiveColumns()

third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/paint/TableSectionPainter.h"
 
 #include "core/layout/LayoutTableCell.h"
 #include "core/layout/LayoutTableCol.h"
 #include "core/layout/LayoutTableRow.h"
 #include "core/paint/BoxClipper.h"
@@ skipping 91 matching lines @@
       box_clipper.emplace(layout_table_section_, paint_info,
                           adjusted_paint_offset, kForceContentsClip);
     PaintObject(paint_info, adjusted_paint_offset);
   }
 
   if (ShouldPaintSelfOutline(paint_info.phase))
     ObjectPainter(layout_table_section_)
         .PaintOutline(paint_info, adjusted_paint_offset);
 }
 
-static inline bool CompareCellPositions(const LayoutTableCell* elem1,
-                                        const LayoutTableCell* elem2) {
-  return elem1->RowIndex() < elem2->RowIndex();
-}
-
 void TableSectionPainter::PaintCollapsedBorders(
     const PaintInfo& paint_info,
     const LayoutPoint& paint_offset,
     const CollapsedBorderValue& current_border_value) {
   PaintCollapsedSectionBorders(paint_info, paint_offset, current_border_value);
   LayoutTable* table = layout_table_section_.Table();
   if (table->Header() == layout_table_section_)
     PaintRepeatingHeaderGroup(paint_info, paint_offset, current_border_value,
                               kPaintCollapsedBorders);
 }
@@ skipping 11 matching lines @@
   BoxClipper box_clipper(layout_table_section_, paint_info,
                          adjusted_paint_offset, kForceContentsClip);
 
   LayoutRect local_visual_rect = LayoutRect(paint_info.GetCullRect().rect_);
   local_visual_rect.MoveBy(-adjusted_paint_offset);
 
   LayoutRect table_aligned_rect =
       layout_table_section_.LogicalRectForWritingModeAndDirection(
           local_visual_rect);
 
-  CellSpan dirtied_rows = layout_table_section_.DirtiedRows(table_aligned_rect);
-  CellSpan dirtied_columns =
-      layout_table_section_.DirtiedEffectiveColumns(table_aligned_rect);
+  CellSpan dirtied_rows;
+  CellSpan dirtied_columns;
+  layout_table_section_.DirtiedRowsAndEffectiveColumns(
+      table_aligned_rect, dirtied_rows, dirtied_columns);
 
-  if (dirtied_columns.Start() >= dirtied_columns.end())
+  if (dirtied_columns.Start() >= dirtied_columns.End())
     return;
 
   // Collapsed borders are painted from the bottom right to the top left so that
   // precedence due to cell position is respected.
-  for (unsigned r = dirtied_rows.end(); r > dirtied_rows.Start(); r--) {
+  for (unsigned r = dirtied_rows.End(); r > dirtied_rows.Start(); r--) {
     unsigned row = r - 1;
     unsigned n_cols = layout_table_section_.NumEffectiveColumns(row);
-    for (unsigned c = std::min(dirtied_columns.end(), n_cols);
+    for (unsigned c = std::min(dirtied_columns.End(), n_cols);
          c > dirtied_columns.Start(); c--) {
       unsigned col = c - 1;
       if (const LayoutTableCell* cell =
               layout_table_section_.OriginatingCellAt(row, col)) {
         LayoutPoint cell_point =
             layout_table_section_.FlipForWritingModeForChild(
                 cell, adjusted_paint_offset);
         TableCellPainter(*cell).PaintCollapsedBorders(paint_info, cell_point,
                                                       current_border_value);
       }
     }
   }
 }
 
 void TableSectionPainter::PaintObject(const PaintInfo& paint_info,
                                       const LayoutPoint& paint_offset) {
   LayoutRect local_visual_rect = LayoutRect(paint_info.GetCullRect().rect_);
   local_visual_rect.MoveBy(-paint_offset);
 
   LayoutRect table_aligned_rect =
       layout_table_section_.LogicalRectForWritingModeAndDirection(
           local_visual_rect);
 
-  CellSpan dirtied_rows = layout_table_section_.DirtiedRows(table_aligned_rect);
-  CellSpan dirtied_columns =
-      layout_table_section_.DirtiedEffectiveColumns(table_aligned_rect);
+  CellSpan dirtied_rows;
+  CellSpan dirtied_columns;
+  layout_table_section_.DirtiedRowsAndEffectiveColumns(
+      table_aligned_rect, dirtied_rows, dirtied_columns);
 
   PaintInfo paint_info_for_descendants = paint_info.ForDescendants();
 
   if (ShouldPaintSelfBlockBackground(paint_info.phase)) {
     PaintBoxDecorationBackground(paint_info, paint_offset, dirtied_rows,
                                  dirtied_columns);
   }
 
   if (paint_info.phase == kPaintPhaseSelfBlockBackgroundOnly)
     return;
 
   if (ShouldPaintDescendantBlockBackgrounds(paint_info.phase)) {
-    for (unsigned r = dirtied_rows.Start(); r < dirtied_rows.end(); r++) {
+    for (unsigned r = dirtied_rows.Start(); r < dirtied_rows.End(); r++) {
       const LayoutTableRow* row = layout_table_section_.RowLayoutObjectAt(r);
       // If a row has a layer, we'll paint row background though
       // TableRowPainter::paint().
       if (!row || row->HasSelfPaintingLayer())
         continue;
       TableRowPainter(*row).PaintBoxDecorationBackground(
           paint_info_for_descendants, paint_offset, dirtied_columns);
     }
   }
 
   // This is tested after background painting because during background painting
   // we need to check validity of the previous background display item based on
   // dirtyRows and dirtyColumns.
-  if (dirtied_rows.Start() >= dirtied_rows.end() ||
-      dirtied_columns.Start() >= dirtied_columns.end())
+  if (dirtied_rows.Start() >= dirtied_rows.End() ||
+      dirtied_columns.Start() >= dirtied_columns.End())
     return;
 
   const auto& overflowing_cells = layout_table_section_.OverflowingCells();
-  if (!layout_table_section_.HasMultipleCellLevels() &&
-      overflowing_cells.IsEmpty()) {
+  if (overflowing_cells.IsEmpty()) {
     // This path is for 2 cases:
-    // 1. Normal partial paint, without overflowing cells and multiple cell
-    //    levels;
+    // 1. Normal partial paint, without overflowing cells;
     // 2. Full paint, for small sections or big sections with many overflowing
     //    cells.
     // The difference between the normal partial paint and full paint is that
     // whether dirtied_rows and dirtied_columns cover the whole section.
     DCHECK(!layout_table_section_.HasOverflowingCell() ||
            (dirtied_rows == layout_table_section_.FullSectionRowSpan() &&
             dirtied_columns ==
                 layout_table_section_.FullTableEffectiveColumnSpan()));
 
-    for (unsigned r = dirtied_rows.Start(); r < dirtied_rows.end(); r++) {
+    for (unsigned r = dirtied_rows.Start(); r < dirtied_rows.End(); r++) {
       const LayoutTableRow* row = layout_table_section_.RowLayoutObjectAt(r);
       // TODO(crbug.com/577282): This painting order is inconsistent with other
       // outlines.
       if (row && !row->HasSelfPaintingLayer() &&
           ShouldPaintSelfOutline(paint_info_for_descendants.phase)) {
         TableRowPainter(*row).PaintOutline(paint_info_for_descendants,
                                            paint_offset);
       }
-      for (unsigned c = dirtied_columns.Start(); c < dirtied_columns.end();
+      for (unsigned c = dirtied_columns.Start(); c < dirtied_columns.End();
            c++) {
         if (const LayoutTableCell* cell =
                 layout_table_section_.OriginatingCellAt(r, c))
           PaintCell(*cell, paint_info_for_descendants, paint_offset);
       }
     }
   } else {
-    // This path paints section with multiple cell levels or a reasonable number
-    // of overflowing cells. This is the "partial paint path" for overflowing
-    // cells referred in LayoutTableSection::ComputeOverflowFromDescendants().
+    // This path paints section with a reasonable number of overflowing cells.
+    // This is the "partial paint path" for overflowing cells referred in
+    // LayoutTableSection::ComputeOverflowFromDescendants().
     Vector<const LayoutTableCell*> cells;
     CopyToVector(overflowing_cells, cells);
 
     HashSet<const LayoutTableCell*> spanning_cells;
-    for (unsigned r = dirtied_rows.Start(); r < dirtied_rows.end(); r++) {
+    for (unsigned r = dirtied_rows.Start(); r < dirtied_rows.End(); r++) {
       const LayoutTableRow* row = layout_table_section_.RowLayoutObjectAt(r);
       // TODO(crbug.com/577282): This painting order is inconsistent with other
       // outlines.
       if (row && !row->HasSelfPaintingLayer() &&
           ShouldPaintSelfOutline(paint_info_for_descendants.phase)) {
         TableRowPainter(*row).PaintOutline(paint_info_for_descendants,
                                            paint_offset);
       }
       unsigned n_cols = layout_table_section_.NumEffectiveColumns(r);
       for (unsigned c = dirtied_columns.Start();
-           c < n_cols && c < dirtied_columns.end(); c++) {
-        for (const auto* cell :
-             layout_table_section_.GridCellAt(r, c).Cells()) {
-          if (overflowing_cells.Contains(cell))
-            continue;
-          if (cell->RowSpan() > 1 || cell->ColSpan() > 1) {
-            if (!spanning_cells.insert(cell).is_new_entry)
-              continue;
-          }
-          cells.push_back(cell);
+           c < n_cols && c < dirtied_columns.End(); c++) {
+        if (const auto* cell = layout_table_section_.OriginatingCellAt(r, c)) {
+          if (!overflowing_cells.Contains(cell))
+            cells.push_back(cell);

[Xianzhu, 2017/05/16 17:18:13]

This is simplified because dirtied_columns and dirtied_rows now cover
originating cells intersecting the dirty rect.

         }
       }
     }
 
     // Sort the dirty cells by paint order.
-    if (!overflowing_cells.size()) {
-      std::stable_sort(cells.begin(), cells.end(), CompareCellPositions);
-    } else {
-      // This comparison is used only when we have overflowing cells as we have
-      // an unsorted array to sort. We thus need to sort both on rows and
-      // columns to paint in proper order.
-      std::sort(cells.begin(), cells.end(), LayoutTableCell::CompareInDOMOrder);
-    }
-
+    std::sort(cells.begin(), cells.end(), LayoutTableCell::CompareInDOMOrder);

[Xianzhu, 2017/05/16 17:18:13]

Now only one sort method left because we enter this path only if there are
overflowing cells.

     for (const auto* cell : cells)
       PaintCell(*cell, paint_info_for_descendants, paint_offset);
   }
 }
 
 void TableSectionPainter::PaintBoxDecorationBackground(
     const PaintInfo& paint_info,
     const LayoutPoint& paint_offset,
     const CellSpan& dirtied_rows,
     const CellSpan& dirtied_columns) {
@@ skipping 23 matching lines @@
       DisplayItem::kBoxDecorationBackground, bounds);
   LayoutRect paint_rect(paint_offset, layout_table_section_.Size());
 
   if (has_box_shadow) {
     BoxPainter::PaintNormalBoxShadow(paint_info, paint_rect,
                                      layout_table_section_.StyleRef());
   }
 
   if (may_have_background) {
     PaintInfo paint_info_for_cells = paint_info.ForDescendants();
-    for (auto r = dirtied_rows.Start(); r < dirtied_rows.end(); r++) {
-      for (auto c = dirtied_columns.Start(); c < dirtied_columns.end(); c++) {
+    for (auto r = dirtied_rows.Start(); r < dirtied_rows.End(); r++) {
+      for (auto c = dirtied_columns.Start(); c < dirtied_columns.End(); c++) {
         if (const auto* cell = layout_table_section_.OriginatingCellAt(r, c)) {
           PaintBackgroundsBehindCell(*cell, paint_info_for_cells, paint_offset);
         }
       }
     }
   }
 
   if (has_box_shadow) {
     // TODO(wangxianzhu): Calculate the inset shadow bounds by insetting
     // paintRect by half widths of collapsed borders.
@@ skipping 44 matching lines @@
                                     const PaintInfo& paint_info_for_cells,
                                     const LayoutPoint& paint_offset) {
   if (!cell.HasSelfPaintingLayer() && !cell.Row()->HasSelfPaintingLayer()) {
     LayoutPoint cell_point =
         layout_table_section_.FlipForWritingModeForChild(&cell, paint_offset);
     cell.Paint(paint_info_for_cells, cell_point);
   }
 }
 
 }  // namespace blink