third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h - Issue 2884703002: Implement CredentialsContainer::create

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

Issue 2884703002: Implement CredentialsContainer::create (Closed)

Patch Set: Nits Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/credentialmanager/CredentialCreationOptions.idl ('k') | third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp » ('j') | third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

diff --git a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

index efaa4f524acf01403eb60a5e9908e1c396591ecb..202041b79aaee5e9654c917631e20a986c8d9678 100644

--- a/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

+++ b/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

@@ -12,6 +12,7 @@

namespace blink {

class Credential;

+class CredentialCreationOptions;

class CredentialRequestOptions;

class ScriptPromise;

class ScriptState;

@@ -24,9 +25,10 @@ class MODULES_EXPORT CredentialsContainer final

public:

static CredentialsContainer* Create();

- // CredentialsContainer.h

+ // CredentialsContainer.idl

ScriptPromise get(ScriptState*, const CredentialRequestOptions&);

ScriptPromise store(ScriptState*, Credential* = 0);

+ ScriptPromise create(ScriptState*, const CredentialCreationOptions&);

ScriptPromise requireUserMediation(ScriptState*);

DEFINE_INLINE_VIRTUAL_TRACE() {}