Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 288463003: Cancel the permission request (Closed)

Created:
6 years, 7 months ago by michaelbai
Modified:
6 years, 7 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cancel the permission request when webview navigates to different page or reload. BUG=373352 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271650

Patch Set 1 : #

Total comments: 6

Patch Set 2 : address comments #

Patch Set 3 : fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -8 lines) Patch
A android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java View 1 1 chunk +157 lines, -0 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +2 lines, -1 line 0 comments Download
M android_webview/native/permission/permission_request_handler.h View 5 chunks +14 lines, -2 lines 0 comments Download
M android_webview/native/permission/permission_request_handler.cc View 1 2 3 chunks +37 lines, -4 lines 0 comments Download
M android_webview/native/permission/permission_request_handler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
michaelbai
6 years, 7 months ago (2014-05-15 23:02:37 UTC) #1
mkosiba (inactive)
lgtm https://codereview.chromium.org/288463003/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java File android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java (right): https://codereview.chromium.org/288463003/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java#newcode42 android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:42: public Uri getOrigin() { I don't see any ...
6 years, 7 months ago (2014-05-19 13:39:36 UTC) #2
michaelbai
https://codereview.chromium.org/288463003/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java File android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java (right): https://codereview.chromium.org/288463003/diff/20001/android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java#newcode42 android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:42: public Uri getOrigin() { methods removed, as this is ...
6 years, 7 months ago (2014-05-19 23:44:06 UTC) #3
michaelbai
The CQ bit was checked by michaelbai@chromium.org
6 years, 7 months ago (2014-05-19 23:44:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/288463003/40001
6 years, 7 months ago (2014-05-19 23:44:27 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 03:07:13 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 03:55:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155265)
6 years, 7 months ago (2014-05-20 03:55:52 UTC) #8
michaelbai
The CQ bit was checked by michaelbai@chromium.org
6 years, 7 months ago (2014-05-20 04:56:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelbai@chromium.org/288463003/60001
6 years, 7 months ago (2014-05-20 04:56:43 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:18:38 UTC) #11
Message was sent while issue was closed.
Change committed as 271650

Powered by Google App Engine
This is Rietveld 408576698