Cancel the permission request

Cancel the permission request when webview navigates to different page or reload.

BUG=373352
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271650

[mkosiba (inactive), 2014-05-19 13:39:36]

lgtm

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
(right):

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:42:
public Uri getOrigin() {
I don't see any of the tests asserting that this value is correct.

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:47:
public long getResources() {
same here.

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:109:
loadUrlSync(awContents, contentsClient.getOnPageFinishedHelper(), mWebRTCPage,
null);
loadUrlAsync should be used in all tests, otherwise you're adding an unnecessary
wait potentially masking race conditions.

[michaelbai, 2014-05-19 23:44:06]

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
File
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java
(right):

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:42:
public Uri getOrigin() {
methods removed, as this is already tested in unit tests

On 2014/05/19 13:39:36, mkosiba wrote:
> I don't see any of the tests asserting that this value is correct.

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:47:
public long getResources() {
On 2014/05/19 13:39:36, mkosiba wrote:
> same here.

Done.

https://codereview.chromium.org/288463003/diff/20001/android_webview/javatest...
android_webview/javatests/src/org/chromium/android_webview/test/MediaAccessPermissionRequestTest.java:109:
loadUrlSync(awContents, contentsClient.getOnPageFinishedHelper(), mWebRTCPage,
null);
On 2014/05/19 13:39:36, mkosiba wrote:
> loadUrlAsync should be used in all tests, otherwise you're adding an
unnecessary
> wait potentially masking race conditions.

Done.

[michaelbai, 2014-05-19 23:44:09]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-05-19 23:44:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelbai@chromium.org/288463003/40001

[commit-bot: I haz the power, 2014-05-20 03:07:13]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-20 03:55:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-20 03:55:52]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[michaelbai, 2014-05-20 04:56:17]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2014-05-20 04:56:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/michaelbai@chromium.org/288463003/60001

[commit-bot: I haz the power, 2014-05-20 15:18:38]

Change committed as 271650