Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 288463002: Remove unneeded kFindInodeSwitch (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, jln (very slow on Chromium)
Visibility:
Public.

Description

Remove unneeded kFindInodeSwitch The last use was removed in r269530. BUG=357670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M base/linux_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M base/linux_util.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mdempsky
6 years, 7 months ago (2014-05-12 23:19:28 UTC) #1
Mark Mentovai
LGTM. I see --find-inode still appearing in sandbox/linux/suid. Should those be removed too?
6 years, 7 months ago (2014-05-13 14:39:16 UTC) #2
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-13 16:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/288463002/1
6 years, 7 months ago (2014-05-13 16:50:55 UTC) #4
mdempsky
On 2014/05/13 14:39:16, Mark Mentovai wrote: > I see --find-inode still appearing in sandbox/linux/suid. Should ...
6 years, 7 months ago (2014-05-13 16:52:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 19:03:42 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 19:53:13 UTC) #7
Message was sent while issue was closed.
Change committed as 270179

Powered by Google App Engine
This is Rietveld 408576698