Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Unified Diff: ash/wm/workspace/backdrop_delegate.h

Issue 2884623002: Refactor backdrop (Closed)
Patch Set: Generalize Backdrop Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/backdrop_delegate.h
diff --git a/ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h b/ash/wm/workspace/backdrop_delegate.h
similarity index 45%
rename from ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h
rename to ash/wm/workspace/backdrop_delegate.h
index 4eaf81b80566f649954f0776f9574589ae674b59..aecf0e81241b5a6e598f82746485f43a8a4fe8c6 100644
--- a/ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h
+++ b/ash/wm/workspace/backdrop_delegate.h
@@ -12,32 +12,14 @@ namespace ash {
class WmWindow;
-namespace wm {
-class WindowState;
-}
-
// A delegate which can be set to create and control a backdrop which gets
// placed below the top level window.
-class ASH_EXPORT WorkspaceLayoutManagerBackdropDelegate {
+class ASH_EXPORT BackdropDelegate {
public:
- virtual ~WorkspaceLayoutManagerBackdropDelegate() {}
+ virtual ~BackdropDelegate() {}
// A window got added to the layout.
- virtual void OnWindowAddedToLayout(WmWindow* child) = 0;
-
- // A window got removed from the layout.
- virtual void OnWindowRemovedFromLayout(WmWindow* child) = 0;
-
- // The visibility of a window has changed.
- virtual void OnChildWindowVisibilityChanged(WmWindow* child,
- bool visible) = 0;
-
- // The stacking order of a window has changed.
- virtual void OnWindowStackingChanged(WmWindow* window) = 0;
-
- // A window state type has changed.
- virtual void OnPostWindowStateTypeChange(wm::WindowState* window_state,
- wm::WindowStateType old_type) = 0;
+ virtual bool HasBackdrop(WmWindow* window) = 0;
};
James Cook 2017/05/15 21:57:39 Hooray, smaller delegate!
oshima 2017/05/16 08:22:09 I was actually wondering if I should just make it
James Cook 2017/05/16 15:12:14 Either way is fine with me.
} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698