Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2884613004: [inspector] added in-deeper-frame continue-to-location strategy

Created:
3 years, 7 months ago by kozy
Modified:
3 years, 5 months ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added deeper-frame continue-to-location targetCallFrames With this target we will break at passed location iff current stack trace is prefix of stack at passed location. BUG=v8:6397 R=dgozman@chromium.org

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -1 line) Patch
M src/inspector/js_protocol.json View 1 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/v8-debugger.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/inspector/v8-stack-trace-impl.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
M test/inspector/debugger/continue-to-location-target-call-frames.js View 1 3 chunks +56 lines, -0 lines 0 comments Download
M test/inspector/debugger/continue-to-location-target-call-frames-expected.txt View 1 1 chunk +69 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2879923003 Patch 60001

Messages

Total messages: 3 (1 generated)
kozy
Dmitry, please take a look.
3 years, 7 months ago (2017-05-16 02:52:47 UTC) #1
dgozman
3 years, 5 months ago (2017-07-15 05:54:01 UTC) #3 
What's the plan here?

Powered by Google App Engine
This is Rietveld 408576698