Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: build/win/merge_pgc_files.py

Issue 2884613003: Update merge_pgc_files.py in preparation for VS2017 (Closed)
Patch Set: raise Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/vs_toolchain.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/win/merge_pgc_files.py
diff --git a/build/win/merge_pgc_files.py b/build/win/merge_pgc_files.py
index a805ba74def2efa00528cef7b2369f5b23655dfa..dac547a0b998cef8bf6c9bec53e2bdb2bfad88b6 100755
--- a/build/win/merge_pgc_files.py
+++ b/build/win/merge_pgc_files.py
@@ -17,6 +17,12 @@ import subprocess
import sys
+script_dir = os.path.dirname(os.path.realpath(__file__))
+sys.path.insert(0, os.path.join(script_dir, os.pardir))
+
+import vs_toolchain
+
+
def find_pgomgr(chrome_checkout_dir):
"""Find pgomgr.exe."""
win_toolchain_json_file = os.path.join(chrome_checkout_dir, 'build',
@@ -30,7 +36,11 @@ def find_pgomgr(chrome_checkout_dir):
# Always use the x64 version of pgomgr (the x86 one doesn't work on the bot's
# environment).
- pgomgr_dir = os.path.join(toolchain_data['path'], 'VC', 'bin', 'amd64')
+ if toolchain_data['version'] == '2015':
+ pgomgr_dir = os.path.join(toolchain_data['path'], 'VC', 'bin', 'amd64')
+ elif toolchain_data['version'] == '2017':
+ vc_tools_root = vs_toolchain.FindVCToolsRoot()
+ pgomgr_dir = os.path.join(vc_tools_root, 'HostX64', 'x64')
pgomgr_path = os.path.join(pgomgr_dir, 'pgomgr.exe')
if not os.path.exists(pgomgr_path):
« no previous file with comments | « build/vs_toolchain.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698