Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Side by Side Diff: chrome/android/java/res/values/dimens.xml

Issue 2884563002: Fix compact infobar height to match the height of Contextual Search. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2014 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <resources> 6 <resources>
7 <!-- Connection info popup dimensions --> 7 <!-- Connection info popup dimensions -->
8 <dimen name="connection_info_padding_wide">24dp</dimen> 8 <dimen name="connection_info_padding_wide">24dp</dimen>
9 <dimen name="connection_info_padding_thin">16dp</dimen> 9 <dimen name="connection_info_padding_thin">16dp</dimen>
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 <dimen name="infobar_control_margin_between_rows">8dp</dimen> 91 <dimen name="infobar_control_margin_between_rows">8dp</dimen>
92 <dimen name="infobar_control_margin_between_columns">32dp</dimen> 92 <dimen name="infobar_control_margin_between_columns">32dp</dimen>
93 93
94 <!-- Dimensions applied to InfoBars with differently sized icons. --> 94 <!-- Dimensions applied to InfoBars with differently sized icons. -->
95 <dimen name="infobar_small_icon_size">24dp</dimen> 95 <dimen name="infobar_small_icon_size">24dp</dimen>
96 <dimen name="infobar_small_icon_margin">8dp</dimen> 96 <dimen name="infobar_small_icon_margin">8dp</dimen>
97 <dimen name="infobar_big_icon_size">48dp</dimen> 97 <dimen name="infobar_big_icon_size">48dp</dimen>
98 <dimen name="infobar_big_icon_margin">16dp</dimen> 98 <dimen name="infobar_big_icon_margin">16dp</dimen>
99 99
100 <!-- Dimensions for compact infobars are a little shorter. --> 100 <!-- Dimensions for compact infobars are a little shorter. -->
101 <dimen name="infobar_compact_size">48dp</dimen> 101 <dimen name="infobar_compact_size">50dp</dimen>
Theresa 2017/05/18 23:43:20 Contextual search maches the toolbar height; in no
102 102
103 <!-- Dimensions for compact translate infobar. --> 103 <!-- Dimensions for compact translate infobar. -->
104 <dimen name="infobar_translate_fade_edge_length">18dp</dimen> 104 <dimen name="infobar_translate_fade_edge_length">18dp</dimen>
105 <dimen name="infobar_translate_menu_width">260dp</dimen> 105 <dimen name="infobar_translate_menu_width">260dp</dimen>
106 106
107 <!-- Contextual search dimensions --> 107 <!-- Contextual search dimensions -->
108 <dimen name="contextual_search_peek_promo_height">48dp</dimen> 108 <dimen name="contextual_search_peek_promo_height">48dp</dimen>
109 <dimen name="contextual_search_peek_promo_padding">12dp</dimen> 109 <dimen name="contextual_search_peek_promo_padding">12dp</dimen>
110 <dimen name="contextual_search_caption_text_size">14sp</dimen> 110 <dimen name="contextual_search_caption_text_size">14sp</dimen>
111 <dimen name="contextual_search_bar_image_size">36dp</dimen> 111 <dimen name="contextual_search_bar_image_size">36dp</dimen>
(...skipping 363 matching lines...) Expand 10 before | Expand all | Expand 10 after
475 <dimen name="context_menu_header_image_min_size">56dp</dimen> 475 <dimen name="context_menu_header_image_min_size">56dp</dimen>
476 <dimen name="context_menu_header_image_max_size">56dp</dimen> 476 <dimen name="context_menu_header_image_max_size">56dp</dimen>
477 477
478 <!-- Divider Dimensions --> 478 <!-- Divider Dimensions -->
479 <dimen name="divider_height">1dp</dimen> 479 <dimen name="divider_height">1dp</dimen>
480 480
481 <!-- Search widget dimensions --> 481 <!-- Search widget dimensions -->
482 <dimen name="search_activity_location_bar_margin_start">16dp</dimen> 482 <dimen name="search_activity_location_bar_margin_start">16dp</dimen>
483 <dimen name="search_activity_location_bar_margin_end">8dp</dimen> 483 <dimen name="search_activity_location_bar_margin_end">8dp</dimen>
484 </resources> 484 </resources>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698