third_party/WebKit/Source/core/frame/NavigatorLanguage.h - Issue 2884493002: Bindings: Require [CachedAttribute] method to be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/NavigatorLanguage.h

Issue 2884493002: Bindings: Require [CachedAttribute] method to be const (Closed)

Patch Set: update binding test expectations Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/NavigatorLanguage.h

diff --git a/third_party/WebKit/Source/core/frame/NavigatorLanguage.h b/third_party/WebKit/Source/core/frame/NavigatorLanguage.h

index e73833ad9dbc3d481ca5b80f8107a640a46ba4d1..974d4ec7529939dc785c38201674ca82a305c4ac 100644

--- a/third_party/WebKit/Source/core/frame/NavigatorLanguage.h

+++ b/third_party/WebKit/Source/core/frame/NavigatorLanguage.h

@@ -16,11 +16,11 @@ class CORE_EXPORT NavigatorLanguage {

AtomicString language();

virtual Vector<String> languages() = 0;

- bool hasLanguagesChanged();

+ bool hasLanguagesChanged() const;

void SetLanguagesChanged();

- private:

- bool languages_changed_;

+ protected:

jsbell 2017/05/16 19:06:46 I don't have a big preference between using `prote

+ bool languages_changed_ = true;

};

} // namespace blink