Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 2884493002: Bindings: Require [CachedAttribute] method to be const (Closed)
Patch Set: update binding test expectations Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
index c41c9ca665fe50bd14b97481c957cdcb460bed82..aa69ee78f43b522d9e7c6085f0ce52baa9547cea 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -2002,7 +2002,7 @@ static void cachedAttributeAnyAttributeAttributeGetter(const v8::FunctionCallbac
V8PrivateProperty::Symbol propertySymbol =
V8PrivateProperty::GetSymbol(info.GetIsolate(),
"TestObject#Cachedattributeanyattribute");
- if (!impl->isValueDirty()) {
+ if (!static_cast<const TestObject*>(impl)->isValueDirty()) {
v8::Local<v8::Value> v8Value = propertySymbol.GetOrUndefined(holder);
if (!v8Value->IsUndefined()) {
V8SetReturnValue(info, v8Value);
@@ -2049,7 +2049,7 @@ static void cachedArrayAttributeAttributeGetter(const v8::FunctionCallbackInfo<v
V8PrivateProperty::Symbol propertySymbol =
V8PrivateProperty::GetSymbol(info.GetIsolate(),
"TestObject#Cachedarrayattribute");
- if (!impl->isArrayDirty()) {
+ if (!static_cast<const TestObject*>(impl)->isArrayDirty()) {
v8::Local<v8::Value> v8Value = propertySymbol.GetOrUndefined(holder);
if (!v8Value->IsUndefined()) {
V8SetReturnValue(info, v8Value);
@@ -2100,7 +2100,7 @@ static void cachedStringOrNoneAttributeAttributeGetter(const v8::FunctionCallbac
V8PrivateProperty::Symbol propertySymbol =
V8PrivateProperty::GetSymbol(info.GetIsolate(),
"TestObject#Cachedstringornoneattribute");
- if (!impl->isStringDirty()) {
+ if (!static_cast<const TestObject*>(impl)->isStringDirty()) {
v8::Local<v8::Value> v8Value = propertySymbol.GetOrUndefined(holder);
if (!v8Value->IsUndefined()) {
V8SetReturnValue(info, v8Value);
@@ -3110,7 +3110,7 @@ static void cachedAttributeRaisesExceptionGetterAnyAttributeAttributeGetter(cons
V8PrivateProperty::Symbol propertySymbol =
V8PrivateProperty::GetSymbol(info.GetIsolate(),
"TestObject#Cachedattributeraisesexceptiongetteranyattribute");
- if (!impl->isValueDirty()) {
+ if (!static_cast<const TestObject*>(impl)->isValueDirty()) {
v8::Local<v8::Value> v8Value = propertySymbol.GetOrUndefined(holder);
if (!v8Value->IsUndefined()) {
V8SetReturnValue(info, v8Value);

Powered by Google App Engine
This is Rietveld 408576698