third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl - Issue 2884493002: Bindings: Require [CachedAttribute] method to be const

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

Issue 2884493002: Bindings: Require [CachedAttribute] method to be const (Closed)

Patch Set: update binding test expectations Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

index b235049b6175ad9973c0f144210d0197a75163f8..3f614943fea1dfa8c31f97df1aa8d1b1597a3865 100644

--- a/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl

@@ -63,7 +63,7 @@ const v8::FunctionCallbackInfo<v8::Value>& info

V8PrivateProperty::Symbol propertySymbol =

V8PrivateProperty::GetSymbol(info.GetIsolate(),

"{{cpp_class}}#{{attribute.name.capitalize()}}");

- if (!impl->{{attribute.cached_attribute_validation_method}}()) {

+ if (!static_cast<const {{cpp_class}}*>(impl)->{{attribute.cached_attribute_validation_method}}()) {

v8::Local<v8::Value> v8Value = propertySymbol.GetOrUndefined(holder);

if (!v8Value->IsUndefined()) {

V8SetReturnValue(info, v8Value);