Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2884483002: Implement function-typed formal parameters in OutlineBuilder. (Closed)
Patch Set: Rework to avoid merge conflicts with https://codereview.chromium.org/2876813002/ Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
index 4cffd0ea693c06ffa6e59b123ff41ac9d3a13935..04e2185071bc4582ffe61b29d3a600d06576ec9f 100644
--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart
+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart
@@ -510,13 +510,14 @@ class OutlineBuilder extends UnhandledListener {
void endFunctionTypedFormalParameter(
Token covariantKeyword, Token thisKeyword, FormalParameterType kind) {
debugEvent("FunctionTypedFormalParameter");
- pop(); // Function type parameters.
- pop(); // Formals offset
- pop(); // Type variables.
+ List<FormalParameterBuilder> formals = pop();
+ int formalsOffset = pop();
+ List<TypeVariableBuilder> typeVariables = pop();
int charOffset = pop();
String name = pop();
- pop(); // Return type.
- push(NullValue.Type);
+ TypeBuilder returnType = pop();
+ push(library.addFunctionType(
+ returnType, typeVariables, formals, formalsOffset));
push(name);
push(charOffset);
}

Powered by Google App Engine
This is Rietveld 408576698