Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2884483002: Implement function-typed formal parameters in OutlineBuilder. (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement function-typed formal parameters in OutlineBuilder. R=ahe@google.com Committed: https://github.com/dart-lang/sdk/commit/bd15c223deb5b78e10d3e62c44ef169380b08f6b

Patch Set 1 #

Patch Set 2 : Reuse new buildType method #

Patch Set 3 : Rework to avoid merge conflicts with https://codereview.chromium.org/2876813002/ #

Messages

Total messages: 5 (2 generated)
Paul Berry
This is needed for type inference, so that calls like x.map(...) know the correct type ...
3 years, 7 months ago (2017-05-12 22:18:28 UTC) #2
ahe
lgtm
3 years, 7 months ago (2017-05-15 12:38:24 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-15 13:28:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
bd15c223deb5b78e10d3e62c44ef169380b08f6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698