Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(930)

Unified Diff: services/ui/ws/window_manager_state.cc

Issue 2884463002: Make event-targeting asynchronous in window server. (Closed)
Patch Set: WeakPtrFactory; const &; etc Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/ui/ws/window_manager_state.cc
diff --git a/services/ui/ws/window_manager_state.cc b/services/ui/ws/window_manager_state.cc
index 00347db7ad2cc15ee378c6f95c68931436a10dd7..4ab74286c575d52fad76b74f89dff822ca978b6f 100644
--- a/services/ui/ws/window_manager_state.cc
+++ b/services/ui/ws/window_manager_state.cc
@@ -290,7 +290,7 @@ void WindowManagerState::ProcessEvent(const ui::Event& event,
int64_t display_id) {
// If this is still waiting for an ack from a previously sent event, then
// queue up the event to be dispatched once the ack is received.
- if (in_flight_event_details_) {
+ if (in_flight_event_details_ || event_dispatcher_.HittestInFlight()) {
sky 2017/05/15 21:20:23 The code you have here will only work if EventDisp
riajiang 2017/05/17 02:01:59 Actually I was looking at |in_flight_event_details
sky 2017/05/17 18:14:43 in_flight_event_details_ is only created from call
riajiang 2017/05/19 16:49:30 I ended up keeping event_dispatcher_.IsHitTestInFl
if (!event_queue_.empty() && !event_queue_.back()->processed_target &&
EventsCanBeCoalesced(*event_queue_.back()->event, event)) {
event_queue_.back()->event = CoalesceEvents(

Powered by Google App Engine
This is Rietveld 408576698