Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2884443002: Remove List.map from analyzer's mock SDK (Closed)

Created:
3 years, 7 months ago by Paul Berry
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove List.map from analyzer's mock SDK In the true SDK, List does not override map()--it inherits the implementation from Iterable. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/cb8ffd969388c3fa0444fae29e7054184e0dee20

Patch Set 1 #

Messages

Total messages: 5 (2 generated)
Paul Berry
3 years, 7 months ago (2017-05-12 18:50:37 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-12 18:51:24 UTC) #3
Paul Berry
3 years, 7 months ago (2017-05-12 19:02:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cb8ffd969388c3fa0444fae29e7054184e0dee20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698