Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 288443005: Add randomized test generation capability to tools/generate-runtime-tests.py (Closed)

Created:
6 years, 7 months ago by Jakob Kummerow
Modified:
6 years, 7 months ago
CC:
v8-dev, Michael Achenbach
Visibility:
Public.

Description

Add randomized test generation capability to tools/generate-runtime-tests.py R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21307

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 4

Patch Set 3 : addressed comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+701 lines, -82 lines) Patch
M tools/generate-runtime-tests.py View 1 2 7 chunks +701 lines, -82 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Jakob Kummerow
Jaro: PTAL. Michael: FYI. optparse :-)
6 years, 7 months ago (2014-05-13 12:06:25 UTC) #1
Jarin
lgtm. Would it make sense to generate global object reference? https://codereview.chromium.org/288443005/diff/20001/tools/generate-runtime-tests.py File tools/generate-runtime-tests.py (right): https://codereview.chromium.org/288443005/diff/20001/tools/generate-runtime-tests.py#newcode255 ...
6 years, 7 months ago (2014-05-14 11:55:08 UTC) #2
Jakob Kummerow
Thanks for the review and the comments. I've added stuff as suggested. On 2014/05/14 11:55:08, ...
6 years, 7 months ago (2014-05-14 12:52:04 UTC) #3
Jakob Kummerow
Committed patchset #3 manually as r21307 (presubmit successful).
6 years, 7 months ago (2014-05-14 12:54:39 UTC) #4
Michael Achenbach
6 years, 7 months ago (2014-05-16 07:23:51 UTC) #5
Message was sent while issue was closed.
Retro LGTM

https://codereview.chromium.org/288443005/diff/40001/tools/generate-runtime-t...
File tools/generate-runtime-tests.py (right):

https://codereview.chromium.org/288443005/diff/40001/tools/generate-runtime-t...
tools/generate-runtime-tests.py:958: process = subprocess.Popen(
Maybe unify this with commands.py in the future?

Powered by Google App Engine
This is Rietveld 408576698