Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: third_party/WebKit/Source/core/input/ScrollManager.cpp

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)
Patch Set: Mark OverscrollRefresh() as protected. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/ScrollManager.cpp
diff --git a/third_party/WebKit/Source/core/input/ScrollManager.cpp b/third_party/WebKit/Source/core/input/ScrollManager.cpp
index 2ec9de28fe33891ae1d881337a6d7b6ba78c3cd7..9a9acccddcf6cc532c0db03ec5a28aab0c871442 100644
--- a/third_party/WebKit/Source/core/input/ScrollManager.cpp
+++ b/third_party/WebKit/Source/core/input/ScrollManager.cpp
@@ -87,6 +87,9 @@ AutoscrollController* ScrollManager::GetAutoscrollController() const {
static bool CanPropagate(const ScrollState& scroll_state,
const Element& element) {
+ if (!element.GetLayoutBox()->GetScrollableArea())
chrishtr 2017/08/25 20:55:06 Why did you need to change this?
sunyunjia 2017/08/25 21:19:44 This is a bug in the previous patch--the scroll-ch
+ return true;
+
return (scroll_state.deltaXHint() == 0 ||
element.GetComputedStyle()->ScrollBoundaryBehaviorX() ==
EScrollBoundaryBehavior::kAuto) &&

Powered by Google App Engine
This is Rietveld 408576698