Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: third_party/WebKit/Source/core/input/ScrollManager.cpp

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)
Patch Set: Update ScrollManager to pass the test. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/ScrollManager.cpp
diff --git a/third_party/WebKit/Source/core/input/ScrollManager.cpp b/third_party/WebKit/Source/core/input/ScrollManager.cpp
index ec6c58ab46b0aeff70daf543c4fe97ad78bc7aff..0c7f1f9dc95dacafc45f2b83527554d083415fe2 100644
--- a/third_party/WebKit/Source/core/input/ScrollManager.cpp
+++ b/third_party/WebKit/Source/core/input/ScrollManager.cpp
@@ -93,6 +93,9 @@ static bool CanPropagate(const ScrollState& scroll_state,
// scroll should be propagated from this node given its relevant*
// ScrollBoundaryBehavior value. * relevant here depends on the dominant
// axis of scroll gesture.
+ // We ignore the scroll-boundary-behavior if the element is not scrollable.
+ if (!element.GetLayoutBox()->GetScrollableArea())
+ return true;
bool x_dominant =
std::abs(scroll_state.deltaXHint()) > std::abs(scroll_state.deltaYHint());
return (x_dominant && element.GetComputedStyle()->ScrollBoundaryBehaviorX() ==

Powered by Google App Engine
This is Rietveld 408576698