third_party/WebKit/Source/core/input/ScrollManager.cpp - Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android.

Unified Diff: third_party/WebKit/Source/core/input/ScrollManager.cpp

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)

Patch Set: Update input_messages with the order in the enum. Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/input/ScrollManager.cpp

diff --git a/third_party/WebKit/Source/core/input/ScrollManager.cpp b/third_party/WebKit/Source/core/input/ScrollManager.cpp

index be52af5fff30e99680f1506e9651b0c6703a9ce1..e2b5f87c21ad4c19d5cb031d47a2764dac124547 100644

--- a/third_party/WebKit/Source/core/input/ScrollManager.cpp

+++ b/third_party/WebKit/Source/core/input/ScrollManager.cpp

@@ -136,7 +136,9 @@ void ScrollManager::RecomputeScrollChain(const Node& start_node,

cur_element == document_element)

break;

- if (!CanPropagate(scroll_state, *cur_element))

+ if (!CanPropagate(scroll_state, *cur_element) &&

+ cur_element !=

+ frame_->GetDocument()->ViewportDefiningElement(nullptr))

majidvp 2017/08/08 15:16:14 This feels odd to me. It is not clear to me why ex

sunyunjia 2017/08/10 16:17:27 Overscroll effect happens deep down at ApplyScroll

majidvp 2017/08/15 14:30:12 We had some offline discussion about this and here

break;

}