ui/events/blink/did_overscroll_params.cc - Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/events/blink/did_overscroll_params.cc

Issue 2884423003: Use scroll-boundary-behavior to control overscroll-refresh/glow on android. (Closed)

Patch Set: Added missing files Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "ui/events/blink/did_overscroll_params.h"	5 #include "ui/events/blink/did_overscroll_params.h"

6	6

7 namespace ui {	7 namespace ui {

8	8

9 DidOverscrollParams::DidOverscrollParams() {}	9 DidOverscrollParams::DidOverscrollParams() {}

10	10

11 DidOverscrollParams::~DidOverscrollParams() {}	11 DidOverscrollParams::~DidOverscrollParams() {}

12	12

	13 void DidOverscrollParams::ClearX() {

	14 accumulated_overscroll.set_x(0);

	15 latest_overscroll_delta.set_x(0);

	16 current_fling_velocity.set_x(0);

	17 }

	18

	19 void DidOverscrollParams::ClearY() {

	20 accumulated_overscroll.set_y(0);

	21 latest_overscroll_delta.set_y(0);

	22 current_fling_velocity.set_y(0);

	23 }
	majidvp 2017/05/18 15:26:10 These methods are used only once and it the logic These methods are used only once and it the logic is pretty simple. I suggest not having them in favor of the same logic at the call site. sunyunjia 2017/05/19 20:14:24 Done. Show quoted text On 2017/05/18 15:26:10, majidvp wrote: > These methods are used only once and it the logic is pretty simple. I suggest > not having them in favor of the same logic > at the call site. Done.
	24

13 } // namespace ui	25 } // namespace ui

OLD	NEW

« ui/events/blink/did_overscroll_params.h ('K') | « ui/events/blink/did_overscroll_params.h ('k') | ui/events/blink/input_handler_proxy.cc » ('j') | no next file with comments »