[WebPayments] Adding FilterProfilesForShipping to profile comparator

components/payments/core/payments_profile_comparator.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_PAYMENTS_CORE_PAYMENTS_PROFILE_COMPARATOR_H_
 #define COMPONENTS_PAYMENTS_CORE_PAYMENTS_PROFILE_COMPARATOR_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 58 matching lines @@
 
   // Returns true iff every contact field requested in |options| is nonempty in
   // |profile|.
   bool IsContactInfoComplete(const autofill::AutofillProfile* profile) const;
 
   // Comparison function suitable for sorting profiles by contact completeness
   // score with std::sort.
   bool IsContactMoreComplete(const autofill::AutofillProfile* p1,
                              const autofill::AutofillProfile* p2) const;
 
+  // Returns profiles for shipping, ordered by completeness. |profiles| should
+  // be passed in order of frecency, and this order will be preserved among
+  // equally-complete profiles.
+  std::vector<autofill::AutofillProfile*> FilterProfilesForShipping(
+      const std::vector<autofill::AutofillProfile*>& profiles) const;
+
+  int GetShippingCompletenessScore(

[Mathieu, 2017/05/16 20:16:51]

can some of these functions be private?

[tmartino, 2017/05/18 20:49:37]

FilterProfilesForShipping: used by State
GetShippingCompletenessScore: public for testing
IsShippingComplete: used by State
IsShippingMoreComplete: Yes, done
GetStringForMissingContactFields: Used by UI

Same applies to Contact equivalents.

+      const autofill::AutofillProfile* profile) const;
+
+  // Returns true iff every field needed to use |profile| as a shipping address
+  // is populated.
+  bool IsShippingComplete(const autofill::AutofillProfile* profile) const;
+
+  bool IsShippingMoreComplete(const autofill::AutofillProfile* p1,
+                              const autofill::AutofillProfile* p2) const;
+
   // Returns a localized string to be displayed in UI indicating what action,
   // if any, must be taken for the given profile to be used as contact info.
   base::string16 GetStringForMissingContactFields(
       const autofill::AutofillProfile& profile) const;
 
-  // Returns true iff every field needed to use |profile| as a shipping address
-  // is populated.
-  bool IsShippingComplete(const autofill::AutofillProfile* profile) const;
-
   // Returns a localized string to be displayed in UI indicating what action,
   // if any, must be taken for the given profile to be used as a shipping
   // address.
   base::string16 GetStringForMissingShippingFields(
       const autofill::AutofillProfile& profile) const;
 
   // Clears the cached evaluation result for |profile|. Must be called when a
   // profile is modified and saved during the course of a PaymentRequest.
   void Invalidate(const autofill::AutofillProfile& profile);
 
  private:
   ProfileFields ComputeMissingFields(
       const autofill::AutofillProfile& profile) const;
   ProfileFields GetRequiredProfileFieldsForContact() const;
   ProfileFields GetRequiredProfileFieldsForShipping() const;
   base::string16 GetStringForMissingFields(ProfileFields fields) const;
   bool AreRequiredAddressFieldsPresent(
       const autofill::AutofillProfile& profile) const;
   mutable std::map<std::string, ProfileFields> cache_;
   const PaymentOptionsProvider& options_;
 };
 
 }  // namespace payments
 
 #endif  // COMPONENTS_PAYMENTS_CORE_PAYMENTS_PROFILE_COMPARATOR_H_