Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2884383005: Revert "Use Kernel frontend from run_vm_tests." (Closed)

Created:
3 years, 7 months ago by Bill Hesse
Modified:
3 years, 7 months ago
Reviewers:
Dmitry Stefantsov
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Use Kernel frontend from run_vm_tests." This reverts commit d91f228766a2c1708bec8f62bbe2756e4a529f5e. The commit causes a failure in tools/build/mac/verify_order _ChromeMain "${BUILT_PRODUCTS_DIR}/${EXECUTABLE_PATH}": unordered symbols in out/Release/Chromium Framework.framework/Versions/A/Chromium Framework: BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/530a0df8f336e5df610a1c783e4ee58530387beb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -259 lines) Patch
M runtime/bin/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 5 chunks +21 lines, -130 lines 0 comments Download
M runtime/include/dart_api.h View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M runtime/vm/kernel_isolate.h View 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/kernel_isolate.cc View 5 chunks +13 lines, -48 lines 0 comments Download
M runtime/vm/unit_test.cc View 3 chunks +5 lines, -49 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
BUG=https://github.com/dart-lang/sdk/issues/29645
3 years, 7 months ago (2017-05-18 08:37:43 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 7 months ago (2017-05-18 08:40:20 UTC) #3
Bill Hesse
3 years, 7 months ago (2017-05-18 08:41:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
530a0df8f336e5df610a1c783e4ee58530387beb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698