fuchsia: base_unittests (mostly) compiling

build/config/compiler/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/chrome_build.gni")
 import("//build/config/chromecast_build.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/toolchain/cc_wrapper.gni")
 import("//build/toolchain/toolchain.gni")
@@ skipping 1073 matching lines @@
 
       # TODO(thakis): This used to be implied by -Wno-unused-function,
       # which we no longer use. Check if it makes sense to remove
       # this as well. http://crbug.com/316352
       "-Wno-unneeded-internal-declaration",
 
       # TODO(hans): Get this cleaned up, http://crbug.com/428099
       "-Wno-inconsistent-missing-override",
     ]
 
-    if (is_linux && target_cpu == "x86") {
+    if ((is_linux && target_cpu == "x86") || is_fuchsia) {

[Nico, 2017/05/17 15:52:54]

1.) If this happens only in ICU, we should suppress it only there, not globally.
2.) Why does this happen for ICU only for fuchsia?

[scottmg, 2017/05/17 16:52:51]

Hmm, #2 is a good question... here's the command lines
https://gist.github.com/sgraham/c806b636d0d58df4f534d100960df103

Digging into the flags a bit (%s/ /^M, %!sort, %!uniq, diff) I get this:

[scottmg:~]$ diff linux.txt fuchsia.txt
2,3c2,3
< --sysroot=../../build/linux/debian_jessie_amd64-sysroot
< -B../../third_party/binutils/Linux_x64/Release/bin
---
12a13
15a17
18,24d19
< -DUSE_AURA=1
< -DUSE_CAIRO=1
< -DUSE_GLIB=1
< -DUSE_NSS_CERTS=1
< -DUSE_PANGO=1
< -DUSE_UDEV
< -DUSE_X11=1
52d46
< -Wno-deprecated
84d77
< -load
90,91c83
< -pthread
< -std=gnu++11
---
94d85
< ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
96d86
< check-ipc

I was hoping it was -std=gnu++11 vs c++11 but it's actually that I didn't turn
on all of the -Wno-deprecated
https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?rcl=5f7ac...
"for hash_map".

       cflags += [
         # TODO(thakis): Remove from 32-bit Linux eventually, https://707084
         "-Wno-deprecated-register",
       ]
     }
 
     # use_xcode_clang only refers to the iOS toolchain, host binaries use
     # chromium's clang always.
     if (!is_nacl && (!use_xcode_clang || current_toolchain == host_toolchain)) {
       # Flags NaCl (Clang 3.7) and Xcode 7.3 (Clang clang-703.0.31) do not
@@ skipping 647 matching lines @@
 
 if (is_ios || is_mac) {
   # On Mac and iOS, this enables support for ARC (automatic ref-counting).
   # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
   config("enable_arc") {
     common_flags = [ "-fobjc-arc" ]
     cflags_objc = common_flags
     cflags_objcc = common_flags
   }
 }