Relocate Windows ProcessNeedsProfileDir to install_static

chrome/install_static/install_util.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file contains helper functions which provide information about the
 // current version of Chrome. This includes channel information, version
 // information etc. This functionality is provided by using functions in
 // kernel32 and advapi32. No other dependencies are allowed in this file.
 
 #ifndef CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
 #define CHROME_INSTALL_STATIC_INSTALL_UTIL_H_
 
 #include <string>
 #include <vector>
 
 namespace version_info {
 enum class Channel;
 }
 
 namespace install_static {
 
 struct InstallConstants;
 
 enum class ProcessType {
   UNINITIALIZED,
-  NON_BROWSER_PROCESS,
+  OTHER_PROCESS,
   BROWSER_PROCESS,
+  CLOUD_PRINT_SERVICE_PROCESS,
+  NACL_BROKER_PROCESS,
+  NACL_LOADER_PROCESS,
 };
 
 // Registry key to store the stats/crash sampling state of Chrome. If set to 1,
 // stats and crash reports will be uploaded in line with the user's consent,
 // otherwise, uploads will be disabled. It is used to sample clients, to reduce
 // server load for metics and crashes. This is controlled by the
 // MetricsReporting feature in chrome_metrics_services_manager_client.cc and is
 // written when metrics services are started up and when consent changes.
 extern const wchar_t kRegValueChromeStatsSample[];
 
@@ skipping 113 matching lines @@
 bool ReportingIsEnforcedByPolicy(bool* crash_reporting_enabled);
 
 // Initializes |g_process_type| which stores whether or not the current
 // process is the main browser process.
 void InitializeProcessType();
 
 // Returns true if invoked in a Chrome process other than the main browser
 // process. False otherwise.
 bool IsNonBrowserProcess();
 
+// Returns true if the |process_type| has the rights to access the profile.
+// False otherwise.
+bool ProcessNeedsProfileDir(const std::string& process_type);
+
 // Populates |crash_dir| with the crash dump location, respecting modifications
 // to user-data-dir.
 // TODO(ananta)
 // http://crbug.com/604923
 // Unify this with the Browser Distribution code.
 std::wstring GetCrashDumpLocation();
 
 // Returns the contents of the specified |variable_name| from the environment
 // block of the calling process. Returns an empty string if the variable does
 // not exist.
@@ skipping 76 matching lines @@
 // from Chrome's ClientState key in the registry. |update_cohort_name|, if not
 // null, is set to the raw "cohort\name" value read from Chrome's ClientState
 // key in the registry.
 std::wstring DetermineChannel(const InstallConstants& mode,
                               bool system_level,
                               bool from_binaries,
                               std::wstring* update_ap,
                               std::wstring* update_cohort_name);
 
 // Caches the |ProcessType| of the current process.
 extern ProcessType g_process_type;

[grt (UTC plus 2), 2017/05/17 20:10:36]

it looks like neither this nor the enum are used outside of the .cc file. would
you move both into an unnamed namespace in the .cc file?

[manzagop (departed), 2017/05/17 21:15:56]

Done.

 
 }  // namespace install_static
 
 #endif  // CHROME_INSTALL_STATIC_INSTALL_UTIL_H_