Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2884273002: Support mixins when loading from .dill (Closed)
Patch Set: Updated cf. comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/kernel_impact.dart
diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart
index 3704f440c10e9441ef351a281700b6341b2d03a1..22b055312868c760264cd19857a4428214e7d727 100644
--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart
+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart
@@ -302,7 +302,12 @@ class KernelImpactBuilder extends ir.Visitor {
@override
void visitSuperInitializer(ir.SuperInitializer node) {
- ConstructorEntity target = elementAdapter.getConstructor(node.target);
+ // TODO(johnniwinther): Maybe rewrite `node.target` to point to a
+ // synthesized unnamed mixin constructor when needed. This would require us
+ // to consider impact building a required pre-step for inference and
+ // ssa-building.
+ ConstructorEntity target =
+ elementAdapter.getSuperConstructor(node.parent, node.target);
_visitArguments(node.arguments);
impactBuilder.registerStaticUse(new StaticUse.superConstructorInvoke(
target, elementAdapter.getCallStructure(node.arguments)));
« no previous file with comments | « pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart ('k') | tests/compiler/dart2js/kernel/closed_world_from_dill_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698