Support mixins when loading from .dill

pkg/compiler/lib/src/ssa/kernel_impact.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:kernel/ast.dart' as ir;
 
 import '../common.dart';
 import '../common/names.dart';
 import '../compiler.dart';
 import '../constants/expressions.dart';
@@ skipping 284 matching lines @@
             "Unexpected constant value in const Symbol(...) call: "
             "${value.toStructuredText()}");
       }
       StringConstantValue stringValue = value;
       impactBuilder.registerConstSymbolName(stringValue.primitiveValue);
     }
   }
 
   @override
   void visitSuperInitializer(ir.SuperInitializer node) {
-    ConstructorEntity target = elementAdapter.getConstructor(node.target);
+    ConstructorEntity target =
+        elementAdapter.getSuperConstructor(node.parent, node.target);

[Siggi Cherem (dart-lang), 2017/05/17 16:50:32]

is node.target here the one that was read from the dill file before adding the
synthetic super constructor? Should we instead rewrite node.target to point to
the right target, then getSuperConstructor becomes getConstructor(target)?

[Johnni Winther, 2017/05/18 08:57:03]

Adding a TODO. I have so far been reluctant to put rewrite logic into
kernel_impact, but we might consider it the required pre-step for inference and
ssa-building. 

     _visitArguments(node.arguments);
     impactBuilder.registerStaticUse(new StaticUse.superConstructorInvoke(
         target, elementAdapter.getCallStructure(node.arguments)));
   }
 
   @override
   void visitStaticInvocation(ir.StaticInvocation node) {
     if (node.target.kind == ir.ProcedureKind.Factory) {
       // TODO(johnniwinther): We should not mark the type as instantiated but
       // rather follow the type arguments directly.
@@ skipping 281 matching lines @@
     ConstructorEntity target = elementAdapter.getConstructor(node.target);
     impactBuilder.registerStaticUse(new StaticUse.superConstructorInvoke(
         target, elementAdapter.getCallStructure(node.arguments)));
   }
 
   // TODO(johnniwinther): Make this throw and visit child nodes explicitly
   // instead to ensure that we don't visit unwanted parts of the ir.
   @override
   void defaultNode(ir.Node node) => node.visitChildren(this);
 }