Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2884233004: Remove some more library directives (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -190 lines) Patch
M pkg/analysis_server/benchmark/integration/driver.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/input_converter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/instrumentation_input_converter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/log_file_input_converter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/main.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/analysis_timing_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_angular.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_flutter.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/benchmark_scenario.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/completion_timing_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/benchmark/perf/performance_tests.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/abstract_context.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/abstract_single_unit.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_hover_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/set_priority_files_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/analysis/test_all.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/channel/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/channel/web_socket_channel_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/completion_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/edit/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/get_errors_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/analysis/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/completion/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/search/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/server/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_queue_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/operation/operation_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/operation/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/plugin/test_all.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/search/search_result_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/search/test_all.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_target_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/completion_manager_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/field_formal_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/inherited_reference_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_member_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/library_prefix_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_declaration_visitor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/local_library_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/optype_test.dart View 3 chunks +41 lines, -42 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/static_member_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/dart/variable_name_contributor_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/statement/statement_completion_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/change_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/flutter_util.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/levenshtein_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/name_suggestion_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/status_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/correction/test_all.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/library_dependencies_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/reachable_source_collector_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/dependencies/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/linter/linter_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/move_file_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/refactoring/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/hierarchy_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/search_engine_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/search/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/services/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/single_context_manager_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/source/caching_put_package_map_provider_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/source/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/src/watch_manager_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/stress/replay/operation.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/instrumentation/log/log.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/check_all_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_analysis_server.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/test/src/utilities/change_builder/test_all.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/check_all_test.dart View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
The only changes in this CL are to remove library directives, but there is one ...
3 years, 7 months ago (2017-05-17 14:52:59 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-17 14:54:49 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-17 15:02:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7d26ff6d4f267d9220525414eacbd0e63ec6bf33 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698