Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4568)

Unified Diff: chrome/browser/resources/md_bookmarks/dnd_manager.js

Issue 2884233003: [MD Bookmarks] Clear drop indicator when dragging over invalid target. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/webui/md_bookmarks/dnd_manager_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/md_bookmarks/dnd_manager.js
diff --git a/chrome/browser/resources/md_bookmarks/dnd_manager.js b/chrome/browser/resources/md_bookmarks/dnd_manager.js
index 4e6d879043e2bd832cb284b38ec8f7777c94c4b7..752c3cfd9129baed8005b7c17bdd1eb2bb1eafe5 100644
--- a/chrome/browser/resources/md_bookmarks/dnd_manager.js
+++ b/chrome/browser/resources/md_bookmarks/dnd_manager.js
@@ -477,8 +477,10 @@ cr.define('bookmarks', function() {
// below based on mouse position etc.
this.dropDestination_ =
this.calculateDropDestination_(e.clientY, overElement);
- if (!this.dropDestination_)
+ if (!this.dropDestination_) {
+ this.dropIndicator_.finish();
return;
+ }
if (e.dataTransfer) {
e.dataTransfer.dropEffect =
« no previous file with comments | « no previous file | chrome/test/data/webui/md_bookmarks/dnd_manager_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698