Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.cc

Issue 2884123003: make chrome build without any printing support (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/renderer/BUILD.gn ('k') | pdf/BUILD.gn » ('j') | pdf/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_devtools_manager_delegate.cc
diff --git a/headless/lib/browser/headless_devtools_manager_delegate.cc b/headless/lib/browser/headless_devtools_manager_delegate.cc
index 291a7850383b18de42415402db3a4af7e0317659..fbe2255116d70e603f22772ddad58d8a246e1304 100644
--- a/headless/lib/browser/headless_devtools_manager_delegate.cc
+++ b/headless/lib/browser/headless_devtools_manager_delegate.cc
@@ -28,11 +28,6 @@ const char kErrorParam[] = "error";
const char kErrorCodeParam[] = "code";
const char kErrorMessageParam[] = "message";
-// The max and min value should match the ones in scaling_settings.html.
-// Update both files at the same time.
-const double kScaleMaxVal = 200;
-const double kScaleMinVal = 10;
-
// JSON RPC 2.0 spec: http://www.jsonrpc.org/specification#error_object
enum Error {
kErrorInvalidParam = -32602,
@@ -96,6 +91,11 @@ void PDFCreated(
} // namespace
#if BUILDFLAG(ENABLE_BASIC_PRINTING)
+// The max and min value should match the ones in scaling_settings.html.
Lei Zhang 2017/05/17 07:01:24 Can you create another anonymous namespace for the
jzfeng 2017/05/19 01:33:53 Done.
+// Update both files at the same time.
+const double kScaleMaxVal = 200;
+const double kScaleMinVal = 10;
+
std::unique_ptr<base::DictionaryValue> ParsePrintSettings(
int command_id,
const base::DictionaryValue* params,
« no previous file with comments | « chrome/renderer/BUILD.gn ('k') | pdf/BUILD.gn » ('j') | pdf/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698