ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html - Issue 2884113002: WebUI: Stop keypresses on the close icon from firing the Enter handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Issue 2884113002: WebUI: Stop keypresses on the close icon from firing the Enter handler. (Closed)

Patch Set: add a test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

diff --git a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

index d36310505612f9afc0a1c7bc7e8ed3a40dc1ab2d..3d82bb3258b5f586fd84dd263b54288a70d6a3c0 100644

--- a/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

+++ b/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

@@ -129,7 +129,7 @@

</div>

<paper-icon-button icon="cr:clear" on-tap="cancel" id="close"

- aria-label$="[[closeText]]">

+ aria-label$="[[closeText]]" on-keypress="onCloseKeypress_">

</paper-icon-button>

</div>