WebUI: Stop keypresses on the close icon from firing the Enter handler.

chrome/test/data/webui/cr_elements/cr_dialog_test.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 suite('cr-dialog', function() {
   function pressEnter(element) {
     MockInteractions.keyEventOn(element, 'keypress', 13, undefined, 'Enter');
   }
 
   setup(function() {
@@ skipping 40 matching lines @@
       clickedCounter++;
     });
 
     // Enter keys on other buttons should be ignored.
     clickedCounter = 0;
     var otherButton = document.body.querySelector('#other-button');
     assertTrue(!!otherButton);
     pressEnter(otherButton);
     assertEquals(0, clickedCounter);
 
+    // Enter keys on the close icon in the top-right corner should be ignored.
+    var closeButton = document.body.querySelector('* /deep/ #close');

[dpapad, 2017/05/15 23:38:56]

Can we use dialog.getCloseButton() instead? See
https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_dialog....

[tommycli, 2017/05/15 23:43:04]

Done.

+    assertTrue(!!closeButton);
+    pressEnter(closeButton);
+    assertEquals(0, clickedCounter);
+
     // Enter key on the action button should only fire the click handler once.
     MockInteractions.tap(actionButton, 'keypress', 13, undefined, 'Enter');

[dpapad, 2017/05/15 23:38:56]

Is the dialog closed (because of the code added above), when this line executes?
I guess that does not create any issue for this test.

[tommycli, 2017/05/15 23:43:04]

I reordered the tests just to be safe.

     assertEquals(1, clickedCounter);
   });
 
   test('enter keys find the first non-hidden non-disabled button', function() {
     document.body.innerHTML = `
       <dialog is="cr-dialog">
         <div class="title">title</div>
         <div class="body">
           <button id="hidden" class="action-button" hidden>hidden</button>
           <button class="action-button" disabled>disabled</button>
@@ skipping 139 matching lines @@
           break;
       }
     });
     observer.observe(bodyContainer, {attributes: true});
 
     // Height is normally set via CSS, but mixin doesn't work with innerHTML.
     bodyContainer.style.height = '60px';  // Element has "min-height: 60px".
     bodyContainer.scrollTop = 100;
   });
 });