Issue 2884051: Merge 53276 - AutoFill Empty profiles should not be saved from AutoFillDialog...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2884051: Merge 53276 - AutoFill Empty profiles should not be saved from AutoFillDialog... (Closed)

Created:
10 years, 4 months ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, John Grabowski, Paweł Hajdan Jr., pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/472/src/

Visibility:
Public.

Description

Merge 53276 - AutoFill Empty profiles should not be saved from AutoFillDialog Add and Edit sheets on Mac. Changes the AutoFillDialog on Mac to not store intermediate results of "Add" and "Edit" actions when those actions result in empty address or credit card information. Empty addresses and credit card information is culled at this level now, not just after "Save" from the main dialog. BUG=47742 TEST=AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewEmptyProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillDialogControllerTest.AddNewEmptyCreditCard Review URL: http://codereview.chromium.org/3061001 TBR=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=54216

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+121 lines, -31 lines)			Patch
M	chrome/browser/autofill/autofill_dialog_controller_mac.mm	View	4 chunks	+35 lines, -15 lines	0 comments	Download
M	chrome/browser/autofill/autofill_dialog_controller_mac_unittest.mm	View	4 chunks	+59 lines, -2 lines	0 comments	Download
M	chrome/browser/autofill/autofill_profile.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/autofill_profile.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/credit_card.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/credit_card.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/autofill/personal_data_manager.cc	View	3 chunks	+4 lines, -14 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages