Issue 2884026: Initial bookmark bar folder window tries harder to be on-screen....

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2884026: Initial bookmark bar folder window tries harder to be on-screen.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 10 months ago by John Grabowski

Modified:
3 years, 11 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Initial bookmark bar folder window tries harder to be on-screen. BUG=http://crbug.com/48832 TEST=Move window all the way to the right of screen so a folder would spill off. Open bookmark bar folder in question --> see it "pushed left" to get back on screen. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53007

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_folder_controller.mm	View		1 chunk	+9 lines, -0 lines	0 comments	Download
	M	chrome/browser/cocoa/bookmark_bar_folder_controller_unittest.mm	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Trybot results: linux mac win

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages