[Mac] Add buttons to the collected cookies dialog to add content exceptions.

[Mac] Add buttons to the collected cookies dialog to add content exceptions.

This is the Mac side of http://codereview.chromium.org/2808053 .

Looks like this: http://imgur.com/leY4C.png

To provide user feedback, after an exception has been added, the exceptions window is shown.

XIB changes:
Add a button to the allowed cookies outline views to block cookies and two to the blocked cookies one to allow them; set the NSSplitView delegate to File's Owner.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=53005

[Bernhard Bauer, 2010-07-19 17:34:46]

Please review.

[Nico, 2010-07-19 18:24:44]

LG with debug junk removed

This dialog looks pretty scary. But since only people who choose "I want pain"
explicitly will see it, I guess that's ok

http://codereview.chromium.org/2884024/diff/1/4
File chrome/browser/cocoa/collected_cookies_mac.mm (right):

http://codereview.chromium.org/2884024/diff/1/4#newcode160
chrome/browser/cocoa/collected_cookies_mac.mm:160: [self 
addException:CONTENT_SETTING_ALLOW
2 more indent

http://codereview.chromium.org/2884024/diff/1/4#newcode161
chrome/browser/cocoa/collected_cookies_mac.mm:161:
forTreeController:blockedTreeController_];
2 more indent

http://codereview.chromium.org/2884024/diff/1/4#newcode164
chrome/browser/cocoa/collected_cookies_mac.mm:164: -
(IBAction)allowForSessionFromOrigin:(id)sender {
dcheck that [sender tag] is either 0 or 1 (if that's true)?

http://codereview.chromium.org/2884024/diff/1/4#newcode168
chrome/browser/cocoa/collected_cookies_mac.mm:168:
forTreeController:controller];
likewise

http://codereview.chromium.org/2884024/diff/1/4#newcode254
chrome/browser/cocoa/collected_cookies_mac.mm:254: //    if
(origin_node->CanCreateContentException()) {
remove?

http://codereview.chromium.org/2884024/diff/1/4#newcode255
chrome/browser/cocoa/collected_cookies_mac.mm:255: if (true) {
remove?

[Bernhard Bauer, 2010-07-19 18:37:02]

On 2010/07/19 18:24:44, Nico wrote:
> LG with debug junk removed
> 
> This dialog looks pretty scary. But since only people who choose "I want pain"
> explicitly will see it, I guess that's ok

:-/ How should I go about making it less scary?

> http://codereview.chromium.org/2884024/diff/1/4
> File chrome/browser/cocoa/collected_cookies_mac.mm (right):
> 
> http://codereview.chromium.org/2884024/diff/1/4#newcode160
> chrome/browser/cocoa/collected_cookies_mac.mm:160: [self 
> addException:CONTENT_SETTING_ALLOW
> 2 more indent
> 
> http://codereview.chromium.org/2884024/diff/1/4#newcode161
> chrome/browser/cocoa/collected_cookies_mac.mm:161:
> forTreeController:blockedTreeController_];
> 2 more indent
> 
> http://codereview.chromium.org/2884024/diff/1/4#newcode164
> chrome/browser/cocoa/collected_cookies_mac.mm:164: -
> (IBAction)allowForSessionFromOrigin:(id)sender {
> dcheck that [sender tag] is either 0 or 1 (if that's true)?
> 
> http://codereview.chromium.org/2884024/diff/1/4#newcode168
> chrome/browser/cocoa/collected_cookies_mac.mm:168:
> forTreeController:controller];
> likewise

done.

> http://codereview.chromium.org/2884024/diff/1/4#newcode254
> chrome/browser/cocoa/collected_cookies_mac.mm:254: //    if
> (origin_node->CanCreateContentException()) {
> remove?

Oops, that shouldn't have been commented out.

> http://codereview.chromium.org/2884024/diff/1/4#newcode255
> chrome/browser/cocoa/collected_cookies_mac.mm:255: if (true) {
> remove?