Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_linux.cc

Issue 2883983004: Linux native notifications: Add hack for xfce4-notifyd spec version (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/notification_platform_bridge_linux.cc
diff --git a/chrome/browser/notifications/notification_platform_bridge_linux.cc b/chrome/browser/notifications/notification_platform_bridge_linux.cc
index 77f73a92b8cd647fe0f5e13482f05937d028e243..8afcb1a7763c06a3576b732c03100c2f0db33466 100644
--- a/chrome/browser/notifications/notification_platform_bridge_linux.cc
+++ b/chrome/browser/notifications/notification_platform_bridge_linux.cc
@@ -461,11 +461,16 @@ class NotificationPlatformBridgeLinuxImpl
dbus::ObjectProxy::TIMEOUT_USE_DEFAULT);
if (server_information_response) {
dbus::MessageReader reader(server_information_response.get());
+ std::string name;
std::string spec_version;
- reader.PopString(&spec_version); // name
+ reader.PopString(&name); // name
reader.PopString(&spec_version); // vendor
reader.PopString(&spec_version); // version
reader.PopString(&spec_version); // spec_version
+ // Hack for xfce4-notifyd. It says it only supports spec
Lei Zhang 2017/05/15 22:32:06 Can you reference https://bugzilla.xfce.org/show_b
+ // version 0.9, but really supports version 1.2.
+ if (name == "Xfce Notify Daemon" && spec_version == "0.9")
+ spec_version = "1.2";
spec_version_ = base::Version(spec_version);
}
// The minimum supported spec version is 1.1, because this was the
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698