Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: content/renderer/browser_plugin/browser_plugin.h

Issue 288393005: Const correctness for some immutable members in BrowserPlugin. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/browser_plugin/browser_plugin.h
diff --git a/content/renderer/browser_plugin/browser_plugin.h b/content/renderer/browser_plugin/browser_plugin.h
index d17615441cb51657aef336caaade7ccbdde052fe..e7fed85a8c5734d06d9e4d75bbea94d3308e5ee4 100644
--- a/content/renderer/browser_plugin/browser_plugin.h
+++ b/content/renderer/browser_plugin/browser_plugin.h
@@ -285,11 +285,11 @@ class CONTENT_EXPORT BrowserPlugin :
// This indicates whether this BrowserPlugin has been attached to a
// WebContents.
bool attached_;
- base::WeakPtr<RenderViewImpl> render_view_;
+ const base::WeakPtr<RenderViewImpl> render_view_;
// We cache the |render_view_|'s routing ID because we need it on destruction.
// If the |render_view_| is destroyed before the BrowserPlugin is destroyed
// then we will attempt to access a NULL pointer.
- int render_view_routing_id_;
+ const int render_view_routing_id_;
blink::WebPluginContainer* container_;
scoped_ptr<BrowserPluginBindings> bindings_;
bool paint_ack_received_;
@@ -311,7 +311,7 @@ class CONTENT_EXPORT BrowserPlugin :
// embedder RenderView's visibility.
bool visible_;
- bool auto_navigate_;
+ const bool auto_navigate_;
std::string html_string_;
WebCursor cursor_;
@@ -323,7 +323,7 @@ class CONTENT_EXPORT BrowserPlugin :
// BrowserPlugin outlives RenderViewImpl in Chrome Apps and so we need to
// store the BrowserPlugin's BrowserPluginManager in a member variable to
// avoid accessing the RenderViewImpl.
- scoped_refptr<BrowserPluginManager> browser_plugin_manager_;
+ const scoped_refptr<BrowserPluginManager> browser_plugin_manager_;
// Used for HW compositing.
scoped_refptr<ChildFrameCompositingHelper> compositing_helper_;
@@ -332,7 +332,7 @@ class CONTENT_EXPORT BrowserPlugin :
scoped_ptr<struct _NPP> npp_;
// URL for the embedder frame.
- GURL embedder_frame_url_;
+ const GURL embedder_frame_url_;
std::vector<EditCommand> edit_commands_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698