Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 288393002: Implement navigator.languages. (Closed)

Created:
6 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
6 years, 6 months ago
CC:
blink-reviews, arv+blink, Inactive, watchdog-blink-watchlist_google.com, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@language_change_tests
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : review comments #

Patch Set 3 : rebase #

Patch Set 4 : fix tests #

Patch Set 5 : error 500 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -4 lines) Patch
M LayoutTests/fast/dom/navigator-detached-no-crash-expected.txt View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/navigator_language/navigator_language.html View 1 2 chunks +43 lines, -1 line 0 comments Download
M Source/core/frame/DOMWindow.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/frame/Navigator.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/frame/Navigator.cpp View 2 chunks +29 lines, -0 lines 0 comments Download
M Source/core/frame/NavigatorLanguage.h View 1 chunk +8 lines, -0 lines 0 comments Download
M Source/core/frame/NavigatorLanguage.cpp View 1 chunk +19 lines, -0 lines 0 comments Download
M Source/core/frame/NavigatorLanguage.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
mlamouri (slow - plz ping)
It is depending on a fix in the bindings generator: https://codereview.chromium.org/282263007/
6 years, 7 months ago (2014-05-16 11:04:30 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/288393002/diff/1/LayoutTests/navigator_language/navigator_language.html File LayoutTests/navigator_language/navigator_language.html (right): https://codereview.chromium.org/288393002/diff/1/LayoutTests/navigator_language/navigator_language.html#newcode90 LayoutTests/navigator_language/navigator_language.html:90: var testValues = [ the entire file violates coding ...
6 years, 7 months ago (2014-05-21 09:10:39 UTC) #2
mlamouri (slow - plz ping)
Review comments applied. PTAL. https://codereview.chromium.org/288393002/diff/1/LayoutTests/navigator_language/navigator_language.html File LayoutTests/navigator_language/navigator_language.html (right): https://codereview.chromium.org/288393002/diff/1/LayoutTests/navigator_language/navigator_language.html#newcode90 LayoutTests/navigator_language/navigator_language.html:90: var testValues = [ On ...
6 years, 7 months ago (2014-05-21 16:45:55 UTC) #3
mlamouri (slow - plz ping)
jochen, did you had a chance to have a look at those changes?
6 years, 7 months ago (2014-05-23 09:53:23 UTC) #4
jochen (gone - plz use gerrit)
lgtm please reference the spec in the CL description
6 years, 7 months ago (2014-05-23 09:55:02 UTC) #5
mlamouri (slow - plz ping)
On 2014/05/23 09:55:02, jochen wrote: > please reference the spec in the CL description Done.
6 years, 7 months ago (2014-05-23 13:45:01 UTC) #6
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 14:36:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/288393002/20001
6 years, 6 months ago (2014-05-30 14:37:07 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 14:37:19 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/DOMWindow.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-05-30 14:37:19 UTC) #10
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 14:46:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/288393002/40001
6 years, 6 months ago (2014-05-30 14:46:43 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-05-30 16:11:37 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-05-30 16:59:27 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/9651) win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9957)
6 years, 6 months ago (2014-05-30 16:59:30 UTC) #15
mlamouri (slow - plz ping)
On 2014/05/30 16:59:30, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-05-30 19:35:14 UTC) #16
mlamouri (slow - plz ping)
The CQ bit was checked by mlamouri@chromium.org
6 years, 6 months ago (2014-05-30 19:35:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlamouri@chromium.org/288393002/80001
6 years, 6 months ago (2014-05-30 19:35:55 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-05-30 22:43:42 UTC) #19
Message was sent while issue was closed.
Change committed as 175161

Powered by Google App Engine
This is Rietveld 408576698