Add service unittest for WakeLockServiceImpl.

services/device/wake_lock/wake_lock_service_impl_unittest.cc

Index: services/device/wake_lock/wake_lock_service_impl_unittest.cc
diff --git a/services/device/wake_lock/wake_lock_service_impl_unittest.cc b/services/device/wake_lock/wake_lock_service_impl_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..111c6b835c1941dfc2530e999887a9c65d5129b3
--- /dev/null
+++ b/services/device/wake_lock/wake_lock_service_impl_unittest.cc
@@ -0,0 +1,190 @@
+// Copyright (c) 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/run_loop.h"
+#include "device/wake_lock/public/interfaces/wake_lock_context.mojom.h"
+#include "device/wake_lock/public/interfaces/wake_lock_provider.mojom.h"
+#include "device/wake_lock/public/interfaces/wake_lock_service.mojom.h"
+#include "mojo/public/cpp/bindings/interface_ptr.h"
+#include "services/device/device_service_test_base.h"
+#include "services/device/public/interfaces/constants.mojom.h"
+
+namespace device {
+
+namespace {
+
+void OnHasWakeLock(bool* out, base::Closure quit_closure, bool has_wakelock) {

[blundell, 2017/05/16 13:37:55]

nit: I would just make this a method of WakeLockServiceImplTest and have a
|has_wakelock_| ivar.

[ke.he, 2017/05/17 07:19:54]

Done.

+  *out = has_wakelock;
+  quit_closure.Run();
+}
+
+class WakeLockServiceImplTest : public DeviceServiceTestBase {
+ public:
+  WakeLockServiceImplTest() = default;
+  ~WakeLockServiceImplTest() override = default;
+
+ protected:
+  void SetUp() override {
+    DeviceServiceTestBase::SetUp();
+    connector()->BindInterface(mojom::kServiceName, &wake_lock_provider_);
+
+    wake_lock_provider_->GetWakeLockWithoutContext(
+        device::mojom::WakeLockType::PreventAppSuspension,
+        device::mojom::WakeLockReason::ReasonOther, "WakeLockServiceImplTest",
+        mojo::MakeRequest(&wake_lock_));
+  }
+
+  bool HasWakeLock() {
+    bool has_wakelock = false;
+
+    base::RunLoop run_loop;
+    wake_lock_->HasWakeLockForTests(
+        base::Bind(&OnHasWakeLock, &has_wakelock, run_loop.QuitClosure()));
+    run_loop.Run();
+
+    return has_wakelock;
+  }
+
+  mojom::WakeLockProviderPtr wake_lock_provider_;
+  mojom::WakeLockServicePtr wake_lock_;
+
+  DISALLOW_COPY_AND_ASSIGN(WakeLockServiceImplTest);
+};
+
+TEST_F(WakeLockServiceImplTest, RequestThenCancel) {
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_->RequestWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+TEST_F(WakeLockServiceImplTest, CancelThenRequest) {
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_->RequestWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+TEST_F(WakeLockServiceImplTest, MultipleRequests) {
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_->RequestWakeLock();
+  wake_lock_->RequestWakeLock();
+  wake_lock_->RequestWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+TEST_F(WakeLockServiceImplTest, OnWakeLockProviderConnectionError) {
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_->RequestWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_provider_.reset();
+  base::RunLoop().RunUntilIdle();
+
+  EXPECT_TRUE(HasWakeLock());
+  wake_lock_->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+TEST_F(WakeLockServiceImplTest, MultipleClients) {
+  EXPECT_FALSE(HasWakeLock());
+
+  mojom::WakeLockServicePtr wake_lock_1;
+  mojom::WakeLockServicePtr wake_lock_2;
+  mojom::WakeLockServicePtr wake_lock_3;
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_1));
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_2));
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_3));
+
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_1->RequestWakeLock();
+  wake_lock_2->RequestWakeLock();
+  wake_lock_3->RequestWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_1->CancelWakeLock();
+  wake_lock_2->CancelWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_3->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+TEST_F(WakeLockServiceImplTest, OnWakeLockConnectionError) {
+  EXPECT_FALSE(HasWakeLock());
+
+  mojom::WakeLockServicePtr wake_lock_1;
+  mojom::WakeLockServicePtr wake_lock_2;
+  mojom::WakeLockServicePtr wake_lock_3;
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_1));
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_2));
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_3));
+
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_1->RequestWakeLock();
+  wake_lock_2->RequestWakeLock();
+  wake_lock_3->RequestWakeLock();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_1.reset();
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_2.reset();
+  wake_lock_3.reset();
+  base::RunLoop().RunUntilIdle();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+TEST_F(WakeLockServiceImplTest, MixedTest) {

[blundell, 2017/05/16 13:37:55]

nit: All of these tests could use 1 line of documentation on what they're
testing.

[ke.he, 2017/05/17 07:19:54]

Done.

+  EXPECT_FALSE(HasWakeLock());
+
+  mojom::WakeLockServicePtr wake_lock_1;
+  mojom::WakeLockServicePtr wake_lock_2;
+  mojom::WakeLockServicePtr wake_lock_3;
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_1));
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_2));
+  wake_lock_->AddClient(mojo::MakeRequest(&wake_lock_3));
+
+  EXPECT_FALSE(HasWakeLock());
+
+  wake_lock_1->RequestWakeLock();

[blundell, 2017/05/16 13:37:55]

This could use a line of documentation on what the output state after this block
is:

// Execute a series of calls that should result in |wake_lock_1| and
|wake_lock_3| having outstanding wake lock requests.

[ke.he, 2017/05/17 07:19:54]

Done.

+  wake_lock_1->CancelWakeLock();
+  wake_lock_2->RequestWakeLock();
+  wake_lock_1->RequestWakeLock();
+  wake_lock_1->RequestWakeLock();
+  wake_lock_3->CancelWakeLock();
+  wake_lock_3->CancelWakeLock();
+  wake_lock_2->CancelWakeLock();
+  wake_lock_3->RequestWakeLock();
+  wake_lock_2.reset();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_1.reset();
+  base::RunLoop().RunUntilIdle();
+  EXPECT_TRUE(HasWakeLock());
+
+  wake_lock_3->CancelWakeLock();
+  EXPECT_FALSE(HasWakeLock());
+}
+
+}  // namespace
+
+}  // namespace device