Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 288383002: Allow comparison in UINT32 mode. (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow comparison in UINT32 mode. Shamelessly based on parts of https://codereview.chromium.org/288853003/. :-) R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21355

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -11 lines) Patch
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-uint32-analysis.cc View 2 chunks +27 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 7 months ago (2014-05-16 08:51:39 UTC) #1
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-16 13:40:27 UTC) #2
Sven Panne
6 years, 7 months ago (2014-05-19 07:47:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21355 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698