Issue 2883793002: Stop sharing two types between wire protocols

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2883793002: Stop sharing two types between wire protocols (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson

Modified:
3 years, 7 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+98 lines, -96 lines)			Patch
M	pkg/analyzer_plugin/doc/api.html	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/protocol/protocol.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer_plugin/lib/protocol/protocol_common.dart	View	2 chunks	+0 lines, -81 lines	0 comments	Download
M	pkg/analyzer_plugin/lib/protocol/protocol_generated.dart	View	1 chunk	+81 lines, -0 lines	0 comments	Download
M	pkg/analyzer_plugin/tool/spec/common_types_spec.html	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	pkg/analyzer_plugin/tool/spec/plugin_spec.html	View	1 chunk	+14 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

We can't share these two types until we start sharing refactoring structures (and I don't ...

3 years, 7 months ago (2017-05-14 17:08:25 UTC) #2

Brian Wilkerson

3 years, 7 months ago (2017-05-15 14:57:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e2ebf96aeafb0564533cdf44dd19fd3a0d627fd0 (presubmit successful).