cc/animation/animation_player.cc - Issue 2883713002: Document some transform node animation fields.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/animation_player.cc

Issue 2883713002: Document some transform node animation fields. (Closed)

Patch Set: Fix comment on node_and_ancestors_are_animated_or_invertible. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/animation/animation_player.cc

diff --git a/cc/animation/animation_player.cc b/cc/animation/animation_player.cc

index 3174dcbdab096b0c5b8c3269e6a638372bdbfa47..66fd35d30be3e4fea632ab7bde6e98e8a7f31913 100644

--- a/cc/animation/animation_player.cc

+++ b/cc/animation/animation_player.cc

@@ -1007,6 +1007,9 @@ bool AnimationPlayer::MaximumTargetScale(ElementListType list_type,

bool AnimationPlayer::IsPotentiallyAnimatingProperty(

TargetProperty::Type target_property,

ElementListType list_type) const {

+ // TODO(wkorman): Consider refactoring this to share implementation

+ // with IsCurrentlyAnimatingProperty. The only difference is

+ // whether we consider InEffect(last_tick_time_) on each.

for (size_t i = 0; i < animations_.size(); ++i) {

if (!animations_[i]->is_finished() &&

animations_[i]->target_property() == target_property) {