Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: cc/trees/property_tree.h

Issue 2883713002: Document some transform node animation fields. (Closed)
Patch Set: Fix comment on node_and_ancestors_are_animated_or_invertible. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CC_TREES_PROPERTY_TREE_H_ 5 #ifndef CC_TREES_PROPERTY_TREE_H_
6 #define CC_TREES_PROPERTY_TREE_H_ 6 #define CC_TREES_PROPERTY_TREE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 294
295 bool source_to_parent_updates_allowed_; 295 bool source_to_parent_updates_allowed_;
296 // When to_screen transform has perspective, the transform node's sublayer 296 // When to_screen transform has perspective, the transform node's sublayer
297 // scale is calculated using page scale factor, device scale factor and the 297 // scale is calculated using page scale factor, device scale factor and the
298 // scale factor of device transform. So we need to store them explicitly. 298 // scale factor of device transform. So we need to store them explicitly.
299 float page_scale_factor_; 299 float page_scale_factor_;
300 float device_scale_factor_; 300 float device_scale_factor_;
301 float device_transform_scale_factor_; 301 float device_transform_scale_factor_;
302 std::vector<int> nodes_affected_by_inner_viewport_bounds_delta_; 302 std::vector<int> nodes_affected_by_inner_viewport_bounds_delta_;
303 std::vector<int> nodes_affected_by_outer_viewport_bounds_delta_; 303 std::vector<int> nodes_affected_by_outer_viewport_bounds_delta_;
304 // TODO(wkorman): Consider renaming cached_data_ to better describe what's
chrishtr 2017/05/13 01:07:18 Not sure if this needs to be a TODO in the code.
wkorman 2017/05/15 19:48:27 Done.
305 // cached.
304 std::vector<TransformCachedNodeData> cached_data_; 306 std::vector<TransformCachedNodeData> cached_data_;
305 std::vector<StickyPositionNodeData> sticky_position_data_; 307 std::vector<StickyPositionNodeData> sticky_position_data_;
306 }; 308 };
307 309
308 struct StickyPositionNodeData { 310 struct StickyPositionNodeData {
309 int scroll_ancestor; 311 int scroll_ancestor;
310 LayerStickyPositionConstraint constraints; 312 LayerStickyPositionConstraint constraints;
311 313
312 // This is the offset that blink has already applied to counteract the main 314 // This is the offset that blink has already applied to counteract the main
313 // thread scroll offset of the scroll ancestor. We need to account for this 315 // thread scroll offset of the scroll ancestor. We need to account for this
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 DrawTransforms& GetDrawTransforms(int transform_id, int effect_id) const; 726 DrawTransforms& GetDrawTransforms(int transform_id, int effect_id) const;
725 DrawTransformData& FetchDrawTransformsDataFromCache(int transform_id, 727 DrawTransformData& FetchDrawTransformsDataFromCache(int transform_id,
726 int effect_id) const; 728 int effect_id) const;
727 729
728 PropertyTreesCachedData cached_data_; 730 PropertyTreesCachedData cached_data_;
729 }; 731 };
730 732
731 } // namespace cc 733 } // namespace cc
732 734
733 #endif // CC_TREES_PROPERTY_TREE_H_ 735 #endif // CC_TREES_PROPERTY_TREE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698