services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom - Issue 2883693002: [Memory-UMA] Implement basic working prototype.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

Issue 2883693002: [Memory-UMA] Implement basic working prototype. (Closed)

Patch Set: Tests working. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« services/resource_coordinator/memory/coordinator/process_map_unittest.cc ('K') | « services/resource_coordinator/memory/coordinator/process_map_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

diff --git a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

index aa1a583efda3b000e943ae2936c3da2c8f2d1964..01c268cfecff2b9145ca03c8cd9c2a09f4a186ce 100644

--- a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

+++ b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

@@ -63,7 +63,9 @@ struct ProcessMemoryDump {

OSMemDump os_dump;

ChromeMemDump chrome_dump;

- // TODO(hjd): add the computed Consistent Memory Metrics footprints here.

+ // This is roughly private, anonymous, non-discardable, resident or swapped

+ // memory. For more details, see https://goo.gl/3kPb9S.

+ uint32 private_footprint = 0;

// This is used only in the use-case (1) and only on Linux/CrOS to get

// around sandboxing. See crbug.com/461788 .