Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4082)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/trace_event/memory_allocator_dump.cc

Issue 2883693002: [Memory-UMA] Implement basic working prototype. (Closed)
Patch Set: Tests working. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/process_memory_metrics_emitter.cc » ('j') | chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/memory_allocator_dump.cc
diff --git a/base/trace_event/memory_allocator_dump.cc b/base/trace_event/memory_allocator_dump.cc
index 2692521c096ab6213cfe1dd20d2a98e8a91ff6ce..e099f1a53e8e729e852e2cc79fbb3cfceb40daa3 100644
--- a/base/trace_event/memory_allocator_dump.cc
+++ b/base/trace_event/memory_allocator_dump.cc
@@ -86,7 +86,6 @@ void MemoryAllocatorDump::AddString(const char* name,
// String attributes are disabled in background mode.
if (process_memory_dump_->dump_args().level_of_detail ==
MemoryDumpLevelOfDetail::BACKGROUND) {
- NOTREACHED();
return;
}
« no previous file with comments | « no previous file | chrome/browser/metrics/process_memory_metrics_emitter.cc » ('j') | chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698