Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1750)

Unified Diff: chrome/browser/metrics/process_memory_metrics_emitter.cc

Issue 2883693002: [Memory-UMA] Implement basic working prototype. (Closed)
Patch Set: Fix test. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/process_memory_metrics_emitter.cc
diff --git a/chrome/browser/metrics/process_memory_metrics_emitter.cc b/chrome/browser/metrics/process_memory_metrics_emitter.cc
index 2b53ff17370fc73ac7d37f4ca6b3fef97dd2e0a6..6cf44b923b715d72f5fcaf5806691857380f1258 100644
--- a/chrome/browser/metrics/process_memory_metrics_emitter.cc
+++ b/chrome/browser/metrics/process_memory_metrics_emitter.cc
@@ -17,36 +17,39 @@ namespace {
void EmitBrowserMemoryMetrics(const ProcessMemoryDumpPtr& pmd) {
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Browser2.Resident",
- pmd->os_dump.resident_set_kb * 1024);
+ pmd->os_dump.resident_set_kb / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Browser2.Malloc",
- pmd->chrome_dump.malloc_total_kb * 1024);
-
- // TODO(erikchen): Emit private memory footprint. https://crbug.com/721434.
+ pmd->chrome_dump.malloc_total_kb / 1024);
+ UMA_HISTOGRAM_MEMORY_LARGE_MB(
+ "Memory.Experimental.Browser2.PrivateMemoryFootprint",
+ pmd->private_footprint / 1024);
}
void EmitRendererMemoryMetrics(const ProcessMemoryDumpPtr& pmd) {
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Renderer2.Resident",
- pmd->os_dump.resident_set_kb * 1024);
+ pmd->os_dump.resident_set_kb / 1024);
+ UMA_HISTOGRAM_MEMORY_LARGE_MB(
+ "Memory.Experimental.Renderer2.PrivateMemoryFootprint",
+ pmd->private_footprint / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Renderer2.Malloc",
- pmd->chrome_dump.malloc_total_kb * 1024);
+ pmd->chrome_dump.malloc_total_kb / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB(
"Memory.Experimental.Renderer2.PartitionAlloc",
- pmd->chrome_dump.partition_alloc_total_kb * 1024);
+ pmd->chrome_dump.partition_alloc_total_kb / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Renderer2.BlinkGC",
- pmd->chrome_dump.blink_gc_total_kb * 1024);
+ pmd->chrome_dump.blink_gc_total_kb / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Renderer2.V8",
- pmd->chrome_dump.v8_total_kb * 1024);
-
- // TODO(erikchen): Emit private memory footprint. https://crbug.com/721434.
+ pmd->chrome_dump.v8_total_kb / 1024);
}
void EmitGpuMemoryMetrics(const ProcessMemoryDumpPtr& pmd) {
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Gpu2.Resident",
- pmd->os_dump.resident_set_kb * 1024);
+ pmd->os_dump.resident_set_kb / 1024);
UMA_HISTOGRAM_MEMORY_LARGE_MB("Memory.Experimental.Gpu2.Malloc",
- pmd->chrome_dump.malloc_total_kb * 1024);
-
- // TODO(erikchen): Emit private memory footprint. https://crbug.com/721434.
+ pmd->chrome_dump.malloc_total_kb / 1024);
+ UMA_HISTOGRAM_MEMORY_LARGE_MB(
+ "Memory.Experimental.Gpu2.PrivateMemoryFootprint",
+ pmd->private_footprint / 1024);
}
} // namespace
« no previous file with comments | « no previous file | chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698