Implement TouchSelectionEditing controls for OOPIF.

content/browser/frame_host/touch_selection_controller_client_child_frame.cc

Index: content/browser/frame_host/touch_selection_controller_client_child_frame.cc
diff --git a/content/browser/frame_host/touch_selection_controller_client_child_frame.cc b/content/browser/frame_host/touch_selection_controller_client_child_frame.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e6ba92ebeba8bcb0c034b01481aa9bcc5b083cbb
--- /dev/null
+++ b/content/browser/frame_host/touch_selection_controller_client_child_frame.cc
@@ -0,0 +1,203 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/frame_host/touch_selection_controller_client_child_frame.h"
+
+#include "content/browser/frame_host/cross_process_frame_connector.h"
+#include "content/browser/frame_host/render_widget_host_view_child_frame.h"
+#include "content/browser/renderer_host/input/touch_selection_controller_client_manager.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
+#include "content/browser/renderer_host/render_widget_host_impl.h"
+#include "content/common/content_switches_internal.h"
+#include "content/common/view_messages.h"
+#include "ui/base/clipboard/clipboard.h"
+#include "ui/gfx/geometry/point_conversions.h"
+#include "ui/strings/grit/ui_strings.h"
+
+namespace content {
+
+TouchSelectionControllerClientChildFrame::
+    TouchSelectionControllerClientChildFrame(
+        RenderWidgetHostViewChildFrame* rwhv,
+        TouchSelectionControllerClientManager* manager)
+    : rwhv_(rwhv), manager_(manager) {
+  DCHECK(rwhv);
+  DCHECK(manager_);
+}
+
+TouchSelectionControllerClientChildFrame::
+    ~TouchSelectionControllerClientChildFrame() {
+  // TODO(wjmaclean): This assumes the manager_ is guaranteed to outlive us,
+  // verify this is true.
+  manager_->InvalidateClient(this);
+}
+
+void TouchSelectionControllerClientChildFrame::UpdateSelectionBoundsIfNeeded(
+    const cc::Selection<gfx::SelectionBound>& selection,
+    float device_scale_factor) {
+  gfx::PointF start_edge_top = selection.start.edge_top();
+  gfx::PointF start_edge_bottom = selection.start.edge_bottom();
+  gfx::PointF end_edge_top = selection.end.edge_top();
+  gfx::PointF end_edge_bottom = selection.end.edge_bottom();
+
+  if (IsUseZoomForDSFEnabled()) {
+    float viewportToDIPScale = 1.0f / device_scale_factor;
+
+    start_edge_top.Scale(viewportToDIPScale);
+    start_edge_bottom.Scale(viewportToDIPScale);
+    end_edge_top.Scale(viewportToDIPScale);
+    end_edge_bottom.Scale(viewportToDIPScale);
+  }
+
+  gfx::Point origin = rwhv_->GetViewOriginInRoot();
+  gfx::Vector2dF offset_v(origin.x(), origin.y());
+  start_edge_top += offset_v;
+  start_edge_bottom += offset_v;
+  end_edge_top += offset_v;
+  end_edge_bottom += offset_v;
+
+  cc::Selection<gfx::SelectionBound> transformed_selection(selection);
+  transformed_selection.start.SetEdge(start_edge_top, start_edge_bottom);
+  transformed_selection.end.SetEdge(end_edge_top, end_edge_bottom);
+
+  if (transformed_selection.start != selection_start_ ||
+      transformed_selection.end != selection_end_) {

[kenrb, 2017/05/23 16:19:02]

I'm not sure that I understand the contention problem properly, but I have a
concern about this. I presume the problem is that frames in separate processes
can have different simultaneous active selections? In that case, what happens if
the top-level frame scrolls? Does that change the selection position in both
frames? If that is true, then this would still be a race between the two RWHVs
becoming the active_frame_ in the manager.

[wjmaclean, 2017/05/23 17:00:41]

I've done this on the assumption that the user is only actively selecting in one
frame at a time, and that frame should be considered active for TSE purposes.

To answer your question: yes, each frame will have its own selection, but for
TSE we will only consider one as active.

I *don't* think we should end up in a race though, at least not if we consider
user-gesture initiated selections. But this code is important since the signal
we're using, namely the selection data in CompositorFrameMetadata, is used no
only to select but also to un-select, or just to re-render a selection from blue
to grey when it is in the frame that is loosing focus. We have no guarantees
about the ordering of the focus related re-rendering events, so this code guards
against make a view the active client when it is just de-focusing *after* the
newly focused view has sent its compositor frame.

[kenrb, 2017/05/24 14:54:28]

Acknowledged.

+    selection_start_ = transformed_selection.start;
+    selection_end_ = transformed_selection.end;
+    manager_->UpdateClientSelectionBounds(selection_start_, selection_end_,
+                                          this, this);
+  }
+}
+
+gfx::Point TouchSelectionControllerClientChildFrame::ConvertFromRoot(
+    const gfx::PointF& point_f) const {
+  gfx::Point origin = rwhv_->GetViewOriginInRoot();
+  return gfx::ToRoundedPoint(
+      gfx::PointF(point_f.x() - origin.x(), point_f.y() - origin.y()));
+}
+
+bool TouchSelectionControllerClientChildFrame::SupportsAnimation() const {
+  return false;

[kenrb, 2017/05/23 16:19:02]

Thinking ahead a bit, is there an easy way to proxy this and SetNeedsAnimate()
to the root RWHV? I think that results in the right behavior on both Aura and
Android, as well as avoiding any #define directives. Or possibly the Aura client
could return without proxying to the internal client.

[wjmaclean, 2017/05/23 17:00:41]

We could just have the TSE Client Manager code not forward to here, meaning the
child frame would always do whatever the root view did (which seems sensible in
and of itself). The manager has access to the root RWHV, so it could be routed
that way.

Should I make that chane in the CL, or is this follow-on work?

Just curious, which #define directives does this avoid (I can't seem to find any
related to this *in the TSE code*.

[kenrb, 2017/05/24 14:54:28]

When this gets wired for Android it would have to be done anyway. I guess it
doesn't matter that much whether this change is done now or then.

I meant that we don't want to add any #defines here when we add Android support.
Android returns true for SupportsAnimation(), and we want this class to be
agnostic.

[wjmaclean, 2017/05/24 17:10:08]

Acknowledged.

+}
+
+void TouchSelectionControllerClientChildFrame::SetNeedsAnimate() {}
+
+void TouchSelectionControllerClientChildFrame::MoveCaret(
+    const gfx::PointF& position) {
+  RenderWidgetHostImpl* host =
+      RenderWidgetHostImpl::From(rwhv_->GetRenderWidgetHost());
+  host->MoveCaret(ConvertFromRoot(position));
+}
+
+void TouchSelectionControllerClientChildFrame::MoveRangeSelectionExtent(
+    const gfx::PointF& extent) {
+  RenderWidgetHostDelegate* host_delegate =
+      RenderWidgetHostImpl::From(rwhv_->GetRenderWidgetHost())->delegate();
+  if (host_delegate)
+    host_delegate->MoveRangeSelectionExtent(ConvertFromRoot(extent));
+}
+
+void TouchSelectionControllerClientChildFrame::SelectBetweenCoordinates(
+    const gfx::PointF& base,
+    const gfx::PointF& extent) {
+  RenderWidgetHostDelegate* host_delegate =
+      RenderWidgetHostImpl::From(rwhv_->GetRenderWidgetHost())->delegate();
+  if (host_delegate) {
+    host_delegate->SelectRange(ConvertFromRoot(base), ConvertFromRoot(extent));
+  }
+}
+
+void TouchSelectionControllerClientChildFrame::OnSelectionEvent(
+    ui::SelectionEventType event) {
+  NOTREACHED();
+}
+
+std::unique_ptr<ui::TouchHandleDrawable>
+TouchSelectionControllerClientChildFrame::CreateDrawable() {
+  NOTREACHED();
+  return std::unique_ptr<ui::TouchHandleDrawable>();
+}
+
+bool TouchSelectionControllerClientChildFrame::IsCommandIdEnabled(
+    int command_id) const {
+  bool editable = rwhv_->GetTextInputType() != ui::TEXT_INPUT_TYPE_NONE;
+  bool readable = rwhv_->GetTextInputType() != ui::TEXT_INPUT_TYPE_PASSWORD;
+  // TODO(wjmaclean): The test for has_selection should be changed to
+  //
+  //  rwhv_->GetSelectionRange(&selection_range);
+  //  bool has_selection = !selection_range.is_empty();
+  //
+  // like in TouchSelectionControllerClientAura. Unfortunately this fails here
+  // due to https://crbug.com/723790, which means that the first text
+  // selected in an oopif subframe when it acquires focus will fail to send
+  // a FrameHostMsg_SelectionChanged, meaning the TextInputManager won't
+  // know about the new selection.
+  bool has_selection = selection_start_.type() != gfx::SelectionBound::EMPTY &&
+                       selection_end_.type() != gfx::SelectionBound::EMPTY &&
+                       selection_start_ != selection_end_;
+  switch (command_id) {
+    case IDS_APP_CUT:
+      return editable && readable && has_selection;
+    case IDS_APP_COPY:
+      return readable && has_selection;
+    case IDS_APP_PASTE: {
+      base::string16 result;
+      ui::Clipboard::GetForCurrentThread()->ReadText(
+          ui::CLIPBOARD_TYPE_COPY_PASTE, &result);
+      return editable && !result.empty();
+    }
+    default:
+      return false;
+  }
+}
+
+void TouchSelectionControllerClientChildFrame::ExecuteCommand(int command_id,
+                                                              int event_flags) {
+  manager_->GetTouchSelectionController()
+      ->HideAndDisallowShowingAutomatically();
+  RenderWidgetHostDelegate* host_delegate =
+      RenderWidgetHostImpl::From(rwhv_->GetRenderWidgetHost())->delegate();
+  if (!host_delegate)
+    return;
+
+  switch (command_id) {
+    case IDS_APP_CUT:
+      host_delegate->Cut();
+      break;
+    case IDS_APP_COPY:
+      host_delegate->Copy();
+      break;
+    case IDS_APP_PASTE:
+      host_delegate->Paste();
+      break;
+    default:
+      NOTREACHED();
+      break;
+  }
+}
+
+void TouchSelectionControllerClientChildFrame::RunContextMenu() {
+  gfx::RectF anchor_rect =
+      manager_->GetTouchSelectionController()->GetRectBetweenBounds();
+  gfx::PointF anchor_point =
+      gfx::PointF(anchor_rect.CenterPoint().x(), anchor_rect.y());
+  gfx::Point origin = rwhv_->GetViewOriginInRoot();
+  anchor_point.Offset(-origin.x(), -origin.y());
+  RenderWidgetHostImpl* host =
+      RenderWidgetHostImpl::From(rwhv_->GetRenderWidgetHost());
+  // TODO(wjmaclean): Probably this ViewMsg should be converted to a FrameMsg
+  // since it will need to go to a RenderFrame once the Blink-side plumbing for
+  // this is hooked up.
+  host->Send(new ViewMsg_ShowContextMenu(host->GetRoutingID(),
+                                         ui::MENU_SOURCE_TOUCH_EDIT_MENU,
+                                         gfx::ToRoundedPoint(anchor_point)));
+
+  // Hide selection handles after getting rect-between-bounds from touch
+  // selection controller; otherwise, rect would be empty and the above
+  // calculations would be invalid.
+  manager_->GetTouchSelectionController()
+      ->HideAndDisallowShowingAutomatically();
+}
+
+}  // namespace content