Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2883653002: Implement TouchSelectionEditing controls for OOPIF. (Closed)
Patch Set: Mark manager's observer as CONTENT_EXPORT. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
68 struct DidOverscrollParams; 68 struct DidOverscrollParams;
69 } 69 }
70 70
71 namespace content { 71 namespace content {
72 class BrowserAccessibilityDelegate; 72 class BrowserAccessibilityDelegate;
73 class BrowserAccessibilityManager; 73 class BrowserAccessibilityManager;
74 class RenderWidgetHostImpl; 74 class RenderWidgetHostImpl;
75 class RenderWidgetHostViewBaseObserver; 75 class RenderWidgetHostViewBaseObserver;
76 class SyntheticGestureTarget; 76 class SyntheticGestureTarget;
77 class TextInputManager; 77 class TextInputManager;
78 class TouchSelectionControllerClientManager;
78 class WebCursor; 79 class WebCursor;
79 struct NativeWebKeyboardEvent; 80 struct NativeWebKeyboardEvent;
80 struct TextInputState; 81 struct TextInputState;
81 82
82 // Basic implementation shared by concrete RenderWidgetHostView subclasses. 83 // Basic implementation shared by concrete RenderWidgetHostView subclasses.
83 class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView, 84 class CONTENT_EXPORT RenderWidgetHostViewBase : public RenderWidgetHostView,
84 public IPC::Listener { 85 public IPC::Listener {
85 public: 86 public:
86 ~RenderWidgetHostViewBase() override; 87 ~RenderWidgetHostViewBase() override;
87 88
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 // TextInputManager if it is destroyed or if the TextInputManager itself is 410 // TextInputManager if it is destroyed or if the TextInputManager itself is
410 // destroyed. The unregistration of the RWHV from TextInputManager is 411 // destroyed. The unregistration of the RWHV from TextInputManager is
411 // necessary and must be done by explicitly calling 412 // necessary and must be done by explicitly calling
412 // TextInputManager::Unregister. 413 // TextInputManager::Unregister.
413 // It is safer to use this method rather than directly dereferencing 414 // It is safer to use this method rather than directly dereferencing
414 // |text_input_manager_|. 415 // |text_input_manager_|.
415 TextInputManager* GetTextInputManager(); 416 TextInputManager* GetTextInputManager();
416 417
417 bool is_fullscreen() { return is_fullscreen_; } 418 bool is_fullscreen() { return is_fullscreen_; }
418 419
420 virtual TouchSelectionControllerClientManager*
kenrb 2017/05/23 16:19:03 A comment could be good here, mentioning that this
wjmaclean 2017/05/23 17:00:41 Done.
421 touch_selection_controller_client_manager();
422
419 // Exposed for testing. 423 // Exposed for testing.
420 virtual bool IsChildFrameForTesting() const; 424 virtual bool IsChildFrameForTesting() const;
421 virtual cc::SurfaceId SurfaceIdForTesting() const; 425 virtual cc::SurfaceId SurfaceIdForTesting() const;
422 426
423 protected: 427 protected:
424 // Interface class only, do not construct. 428 // Interface class only, do not construct.
425 RenderWidgetHostViewBase(); 429 RenderWidgetHostViewBase();
426 430
427 void NotifyObserversAboutShutdown(); 431 void NotifyObserversAboutShutdown();
428 432
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
467 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 471 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
468 472
469 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 473 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
470 474
471 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 475 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
472 }; 476 };
473 477
474 } // namespace content 478 } // namespace content
475 479
476 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 480 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698