Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3438)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java

Issue 2883643002: Clean up ReaderMode OverlayPanel classes (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/OWNERS » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
index 5c817e4a3e96d209fa39ffa03d3eea0a8528a718..ee71cce5d5b925c77738e1a7e3b43da73d4f5589 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java
@@ -54,7 +54,6 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState
/**
* The reason for a change in the Overlay Panel's state.
- * TODO(mdjones): Separate generic reasons from Contextual Search reasons.
*/
public enum StateChangeReason {
UNKNOWN,
@@ -77,13 +76,6 @@ public class OverlayPanel extends OverlayPanelAnimation implements ActivityState
CLOSE_BUTTON,
SUPPRESS,
UNSUPPRESS,
- FULLSCREEN_ENTERED,
- FULLSCREEN_EXITED,
- INFOBAR_SHOWN,
- INFOBAR_HIDDEN,
- CONTENT_CHANGED,
- KEYBOARD_SHOWN,
- KEYBOARD_HIDDEN,
TAB_NAVIGATION
wychen 2017/05/22 23:12:36 Is this still used?
mdjones 2017/06/13 23:03:31 Nope, removed.
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/readermode/OWNERS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698