components/dom_distiller/content/common/distiller_javascript_service.mojom - Issue 2883643002: Clean up ReaderMode OverlayPanel classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/common/distiller_javascript_service.mojom

Issue 2883643002: Clean up ReaderMode OverlayPanel classes (Closed)

Patch Set: remove extra enum Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/DomDistillerUIUtils.java ('K') | « components/dom_distiller/content/browser/distiller_ui_handle.h ('k') | components/dom_distiller/content/renderer/distiller_native_javascript.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/common/distiller_javascript_service.mojom

diff --git a/components/dom_distiller/content/common/distiller_javascript_service.mojom b/components/dom_distiller/content/common/distiller_javascript_service.mojom

index 8589198d0ed7254a4d4bc153763866a1c04b4e59..ffe03bac5186b5708cdd7a73a1ed2c7cee58132b 100644

--- a/components/dom_distiller/content/common/distiller_javascript_service.mojom

+++ b/components/dom_distiller/content/common/distiller_javascript_service.mojom

@@ -7,10 +7,6 @@ module dom_distiller.mojom;

// This service is implemented by the browser process and is used by the

// renderer when a distiller JavaScript function is called.

interface DistillerJavaScriptService {

- // Handle closing the overlay panel that contains Reader Mode; the

- // "distiller.close" function.

- HandleDistillerClosePanelCall(bool animate);

// Open the Android view containing settings for Reader Mode; the

// "distiller.openSettings" function.

HandleDistillerOpenSettingsCall();